Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return correct action responses for bulk delete #180

Merged
merged 2 commits into from Nov 8, 2017

Conversation

@jntullo
Copy link
Contributor

jntullo commented Nov 7, 2017

The way deleting works now is that resource search happens prior to the rescue block, which is causing an issue when the first item in bulk deletion happens- it raises a not found when it should just be an action response and continue on to delete the other resources. This PR leverages the existing delete_action_handler to ensure that not founds get returned for single resource actions, but action results are returned for bulk actions.

https://bugzilla.redhat.com/show_bug.cgi?id=1504693

@miq-bot add_label bug, gaprindashvili/yes
@miq-bot assign @abellotti

Jillian Tullo added 2 commits Nov 7, 2017
…urces

The way deleting works now is that resource search happens prior to the rescue block, which is causing an issue when the first item in bulk deletion happens, it raises a not found when it should just be an action response. This PR leverages the existing delete_action_handler to ensure that not founds get returned for single resource actions, but action results are returned for bulk actions.

https://bugzilla.redhat.com/show_bug.cgi?id=1504693
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Nov 7, 2017

Checked commits jntullo/manageiq-api@73efb39~...7d229d3 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks fine. ⭐️

Copy link
Member

chrisarcand left a comment

Nice, looks great @jntullo

@chrisarcand chrisarcand merged commit 5910269 into ManageIQ:master Nov 8, 2017
3 checks passed
3 checks passed
Hakiri No security warnings were found.
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chrisarcand chrisarcand assigned chrisarcand and unassigned abellotti Nov 8, 2017
simaishi added a commit that referenced this pull request Nov 14, 2017
Return correct action responses for bulk delete
(cherry picked from commit 5910269)

https://bugzilla.redhat.com/show_bug.cgi?id=1511128
@simaishi

This comment has been minimized.

Copy link
Contributor

simaishi commented Nov 14, 2017

Gaprindashvili backport details:

$ git log -1
commit 8d77e60f665a95beb49f74ea2f9f21efec982e22
Author: Chris Arcand <chrisarcand@users.noreply.github.com>
Date:   Tue Nov 7 23:43:35 2017 -0600

    Merge pull request #180 from jntullo/bz/bulk_delete
    
    Return correct action responses for bulk delete
    (cherry picked from commit 59102695a45f3e717e1df39085f1c59aa692ea19)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1511128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.