New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPTIONS for /api/providers #3

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@enoodle

enoodle commented Aug 8, 2017

This is a migration of ManageIQ/manageiq#15660

@enoodle

This comment has been minimized.

Show comment
Hide comment
@enoodle

enoodle commented Aug 8, 2017

Show outdated Hide outdated app/controllers/api/providers_controller.rb Outdated
Show outdated Hide outdated app/controllers/api/providers_controller.rb Outdated

@enoodle enoodle closed this Aug 9, 2017

@enoodle enoodle reopened this Aug 9, 2017

@imtayadeway

This comment has been minimized.

Show comment
Hide comment
@imtayadeway

imtayadeway Aug 9, 2017

Contributor

@enoodle just one more suggestion in #3 (comment). Thanks!

Contributor

imtayadeway commented Aug 9, 2017

@enoodle just one more suggestion in #3 (comment). Thanks!

@enoodle

This comment has been minimized.

Show comment
Hide comment
@enoodle

enoodle commented Aug 10, 2017

@enoodle

This comment has been minimized.

Show comment
Hide comment
@enoodle

enoodle commented Aug 14, 2017

@imtayadeway

LGTM! Thanks @enoodle for your patience with my many questions.

Off to @abellotti

@enoodle enoodle changed the title from OPTIONS for /api/providers to [WIP] OPTIONS for /api/providers Aug 15, 2017

@enoodle

This comment has been minimized.

Show comment
Hide comment
@enoodle

enoodle Aug 15, 2017

@miq-bot add_label wip
We will change the provider_settings function name to options_description

enoodle commented Aug 15, 2017

@miq-bot add_label wip
We will change the provider_settings function name to options_description

@miq-bot miq-bot added the wip label Aug 15, 2017

@enoodle enoodle changed the title from [WIP] OPTIONS for /api/providers to OPTIONS for /api/providers Aug 24, 2017

@enoodle enoodle closed this Aug 24, 2017

@enoodle enoodle reopened this Aug 24, 2017

@miq-bot miq-bot removed the wip label Aug 24, 2017

@enoodle

This comment has been minimized.

Show comment
Hide comment
@enoodle

enoodle Aug 24, 2017

@imtayadeway @abellotti with ManageIQ/manageiq#15799 being approved, can we merge this one?

enoodle commented Aug 24, 2017

@imtayadeway @abellotti with ManageIQ/manageiq#15799 being approved, can we merge this one?

@abellotti

This comment has been minimized.

Show comment
Hide comment
@abellotti

abellotti Aug 24, 2017

Member

@enoodle can you attach sample output you're getting with OPTIONS /api/providers ? just the data part of the output is sufficient. Thanks.

Member

abellotti commented Aug 24, 2017

@enoodle can you attach sample output you're getting with OPTIONS /api/providers ? just the data part of the output is sufficient. Thanks.

@enoodle

This comment has been minimized.

Show comment
Hide comment
@enoodle

enoodle Aug 24, 2017

Output example from current masters:

api_provider_to_delete.txt

enoodle commented Aug 24, 2017

Output example from current masters:

api_provider_to_delete.txt

@abellotti

This comment has been minimized.

Show comment
Hide comment
@abellotti

abellotti Aug 24, 2017

Member

I wonder if there might be some common options we'd want to provide in the future for all providers, in which case we may want to nest the output one level down,

i.e.

"data" => {
   "provider_settings" => {
       "ansible_tower_automation" => ...,
       "azure" => ...,
       ...
   }
}
Member

abellotti commented Aug 24, 2017

I wonder if there might be some common options we'd want to provide in the future for all providers, in which case we may want to nest the output one level down,

i.e.

"data" => {
   "provider_settings" => {
       "ansible_tower_automation" => ...,
       "azure" => ...,
       ...
   }
}
@enoodle

This comment has been minimized.

Show comment
Hide comment
@enoodle

enoodle Aug 25, 2017

@abellotti Then you suggest to have the common options description under "provider_settings"? It will make for a more compact output, but will be more awkward to consume so I don't like it too much.

enoodle commented Aug 25, 2017

@abellotti Then you suggest to have the common options description under "provider_settings"? It will make for a more compact output, but will be more awkward to consume so I don't like it too much.

@abellotti

This comment has been minimized.

Show comment
Hide comment
@abellotti

abellotti Aug 30, 2017

Member

@enoodle true, it is an extra level to fetch, but would keep the return signature future-proof.

Member

abellotti commented Aug 30, 2017

@enoodle true, it is an extra level to fetch, but would keep the return signature future-proof.

@enoodle

This comment has been minimized.

Show comment
Hide comment
@enoodle

enoodle Sep 3, 2017

@abellotti 👍 I added the "provider_settings" step.

enoodle commented Sep 3, 2017

@abellotti 👍 I added the "provider_settings" step.

Erez Freiberger
@miq-bot

This comment has been minimized.

Show comment
Hide comment
@miq-bot

miq-bot Sep 4, 2017

Member

Checked commit enoodle@cb3b52c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

app/controllers/api/providers_controller.rb

Member

miq-bot commented Sep 4, 2017

Checked commit enoodle@cb3b52c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

app/controllers/api/providers_controller.rb

@enoodle

This comment has been minimized.

Show comment
Hide comment
@enoodle

enoodle Sep 4, 2017

Travis for this seems to be broken as it is testing the wrong commit. I will close this one to open a new PR.

enoodle commented Sep 4, 2017

Travis for this seems to be broken as it is testing the wrong commit. I will close this one to open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment