Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the task message into check for task presence #283

Merged
merged 1 commit into from
May 1, 2018
Merged

Move the task message into check for task presence #283

merged 1 commit into from
May 1, 2018

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Apr 19, 2018

The updated message should only include the task message if the task exists.

@d-m-u
Copy link
Contributor Author

d-m-u commented Apr 19, 2018

@tinaafitz please review
@miq-bot add_label bug

@miq-bot miq-bot added the bug label Apr 19, 2018
@miq-bot
Copy link
Member

miq-bot commented Apr 19, 2018

Checked commit d-m-u@dd05428 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-m-u Looks good.
@mkanoor Please review.

@gmcculloug gmcculloug self-assigned this Apr 23, 2018
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-m-u Looks good.

@gmcculloug gmcculloug merged commit 98ebb01 into ManageIQ:master May 1, 2018
@gmcculloug gmcculloug added this to the Sprint 85 Ending May 7, 2018 milestone May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants