Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINE] load regions list from aws-sdk gem's source & disable special ones #447

Closed

Conversation

AlexanderZagaynov
Copy link
Contributor

@AlexanderZagaynov AlexanderZagaynov commented May 18, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1500613
This is a cherry-picks from:
#265, #392, #436, #443, #446
@simaishi please review

@miq-bot miq-bot changed the title load regions list from aws-sdk gem's source & disable special ones [FINE] load regions list from aws-sdk gem's source & disable special ones May 18, 2018
@simaishi
Copy link
Contributor

simaishi commented May 18, 2018

@AlexanderZagaynov @bronaghs A few questions...

  1. The BZ is marked to be fixed for 'master' branch only. If we need/want to fix in Fine branch, we must also fix in gaprindashvili branch. Please make sure gaprindashvili/yes label exists on all needed PRs.

  2. Are those cherry-picks not clean? We always prefer a cherry-pick over a separate PR for G/F branches, if possible.

@simaishi simaishi self-assigned this May 18, 2018
@AlexanderZagaynov
Copy link
Contributor Author

@simaishi Version field's value in that BZ is 5.8.0.
I understood that as I should prepare a PR for Fine.
Even more you mentioned PR necessity here: #443 (comment)
Those commits can't be simply cherry-picked, I had to solve a couple of merge conflicts.
For Gaprindashvili I guess those commits can be cherry-picked directly.

@simaishi
Copy link
Contributor

simaishi commented May 18, 2018

Thanks for clarifying about cherry-pick.

"version" indicates where the issue was found, and doesn't always match which version we want to fix in... The version we want to fix shows up as Target Release in BZ. That's why I asked... @bronaghs please confirm we want to fix this in G/F branch as well.

@miq-bot
Copy link
Member

miq-bot commented May 18, 2018

Checked commits AlexanderZagaynov/manageiq-providers-amazon@2f4d0a6~...428546f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@bronaghs
Copy link

hi @AlexanderZagaynov, @simaishi
This does not need to be backported to fine or gaprandishvili (target release of https://bugzilla.redhat.com/show_bug.cgi?id=1500613 is 5.10 and loading regions from aws-sdk gem is an RFE).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants