Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Storage Devices parser #150

Merged

Conversation

douglasgabriel
Copy link
Member

@douglasgabriel douglasgabriel commented Apr 6, 2018

This PR is able to:

  • Add Storage Devices to guest_devices physical server prop;
  • Create StorageDeviceParser to parse the storage devices informations;
  • Add some specs for new devices.

@douglasgabriel douglasgabriel force-pushed the add_parser_storage_devices branch 2 times, most recently from 803b6d7 to b7cba79 Compare April 6, 2018 12:32
@douglasgabriel
Copy link
Member Author

@miq-bot assign @agrare

@douglasgabriel douglasgabriel force-pushed the add_parser_storage_devices branch 2 times, most recently from 2efa1fb to 9e90858 Compare April 6, 2018 14:32
@miq-bot
Copy link
Member

miq-bot commented Apr 6, 2018

This pull request is not mergeable. Please rebase and repush.

@douglasgabriel
Copy link
Member Author

@miq-bot remove_label unmergeable

@douglasgabriel
Copy link
Member Author

@miq-bot add_reviewer @rodneyhbrown7

@miq-bot
Copy link
Member

miq-bot commented Apr 6, 2018

Checked commit douglasgabriel@e1a7aa0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🍪

@rodneyhbrown7 rodneyhbrown7 merged commit 2081cc4 into ManageIQ:master Apr 9, 2018
@agrare agrare added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants