Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content library collection NilClass error #652

Merged
merged 1 commit into from Oct 19, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Oct 19, 2020

The VSphereAutomationApi can return nil for #list actions which can cause the refresh to fail:

[NoMethodError]: undefined method value' for nil:NilClass Method:[block (2 levels) in <class:LogProxy>]
[----] E, [2020-10-16T08:39:38.592012 #25472:2ac168d965f8] ERROR -- : manageiq-providers-vmware-cf1ed2fec79c/app/models/manageiq/providers/vmware/infra_manager/inventory/collector.rb:312:in parse_content_libraries'

@agrare agrare requested a review from Fryguy as a code owner October 19, 2020 12:57
@agrare agrare added the bug label Oct 19, 2020
The VSphereAutomationApi can return `nil` for `#list` actions which can
cause the refresh to fail
@agrare agrare force-pushed the fix_fetch_content_libraries branch from 9dcf0b8 to 4e8c03c Compare October 19, 2020 13:00
@miq-bot
Copy link
Member

miq-bot commented Oct 19, 2020

Checked commit agrare@4e8c03c with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy Fryguy merged commit 1be076a into ManageIQ:master Oct 19, 2020
@Fryguy Fryguy self-assigned this Oct 19, 2020
@agrare agrare deleted the fix_fetch_content_libraries branch October 19, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants