From 79226e4976b37e35a591f0c18f8ce61a0456f927 Mon Sep 17 00:00:00 2001 From: Hilda Stastna Date: Thu, 31 Oct 2019 17:44:06 +0100 Subject: [PATCH] Make Save button disabled after canceling User's password change Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1762791 --- app/assets/javascripts/miq_change_stored_password.js | 8 ++++++-- app/views/ops/_rbac_user_details.html.haml | 3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/miq_change_stored_password.js b/app/assets/javascripts/miq_change_stored_password.js index e8bd74125c4..d535a315a46 100644 --- a/app/assets/javascripts/miq_change_stored_password.js +++ b/app/assets/javascripts/miq_change_stored_password.js @@ -12,6 +12,8 @@ function changeStoredPassword(pfx, url) { $('#' + prefix + 'verify').removeAttr('disabled'); $('#' + prefix + 'password').val(''); $('#' + prefix + 'verify').val(''); + $('#' + prefix + 'password').attr('placeholder', ''); + $('#' + prefix + 'verify').attr('placeholder', ''); miqJqueryRequest(url + '?' + prefix + 'password' + '=' + '&' + prefix + 'verify' + '='); $('#' + prefix + 'password').focus(); } @@ -27,7 +29,9 @@ function cancelPasswordChange(pfx, url) { $('#' + prefix + 'verify_group').css('display', 'none'); $('#' + prefix + 'password').attr('disabled', 'disabled'); $('#' + prefix + 'verify').attr('disabled', 'disabled'); - $('#' + prefix + 'password').val(storedPasswordPlaceholder); - $('#' + prefix + 'verify').val(storedPasswordPlaceholder); + $('#' + prefix + 'password').attr('placeholder', storedPasswordPlaceholder); + $('#' + prefix + 'verify').attr('placeholder', storedPasswordPlaceholder); + $('#' + prefix + 'password').val(''); + $('#' + prefix + 'verify').val(''); miqJqueryRequest(url + '?' + prefix + 'password' + '=' + '&' + prefix + 'verify' + '=' + '&restore_password=true'); } diff --git a/app/views/ops/_rbac_user_details.html.haml b/app/views/ops/_rbac_user_details.html.haml index aa36ea243c8..d01d0f9c8e1 100644 --- a/app/views/ops/_rbac_user_details.html.haml +++ b/app/views/ops/_rbac_user_details.html.haml @@ -61,9 +61,10 @@ .col-md-8 %span.input-group{:style => "width: 100%"} = password_field_tag("password", - @edit[:new][:userid].blank? ? "" : stored_password_placeholder, + "", :maxlength => 50, :disabled => @edit[:new][:userid].blank? ? false : true, + :placeholder => @edit[:new][:userid].blank? ? "" : stored_password_placeholder, :class => "form-control", "data-miq_observe" => observe_url_json) - if @edit[:new][:userid] == "admin"