From e87c6baa217b5d5384d96e930e2d11140ea3f5be Mon Sep 17 00:00:00 2001 From: Dan Clarizio Date: Thu, 8 Mar 2018 11:01:33 -0800 Subject: [PATCH] Merge pull request #3531 from mansam/filter-networks-for-floating-ips Apply RBAC filtering to cloud networks when creating floating ips (cherry picked from commit 4773d1fae2f9b367d982c9f339d185f615a2f2e9) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1553787 --- app/controllers/floating_ip_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/floating_ip_controller.rb b/app/controllers/floating_ip_controller.rb index 2d93ff0b62e..43fb2d21dac 100644 --- a/app/controllers/floating_ip_controller.rb +++ b/app/controllers/floating_ip_controller.rb @@ -152,7 +152,7 @@ def floating_ip_form_fields def networks_by_ems assert_privileges("floating_ip_new") networks = [] - available_networks = CloudNetwork.where(:ems_id => params[:id], :external_facing => true).find_each + available_networks = Rbac::Filterer.filtered(CloudNetwork.where(:ems_id => params[:id], :external_facing => true)) available_networks.each do |network| networks << { 'name' => network.name, 'id' => network.id } end