From fcb8fc1cb4f2aa6a7cb1ed689fa4fec9f6cb948f Mon Sep 17 00:00:00 2001 From: Jason Frey Date: Fri, 24 May 2024 09:41:51 -0400 Subject: [PATCH] Merge pull request #9184 from jaisejose1123/fix_vault_credentials Fix for vault credentials in service-catalog's provisioning and retirement summary (cherry picked from commit 36e192bafa6f0178d2d1e120d8c31be77dbdd044) --- app/helpers/catalog_helper.rb | 1 - .../schema.js | 8 +- .../ansible-edit-catalog-form.spec.js.snap | 652 +++++++++--------- 3 files changed, 330 insertions(+), 331 deletions(-) diff --git a/app/helpers/catalog_helper.rb b/app/helpers/catalog_helper.rb index b4a1e850fac..6d665742e56 100644 --- a/app/helpers/catalog_helper.rb +++ b/app/helpers/catalog_helper.rb @@ -193,7 +193,6 @@ def catalog_generic_template_info(type, record, info) rows.push(row_data(_('Playbook'), info[:playbook])) rows.push(row_data(_('Machine Credential'), info[:machine_credential])) rows.push(row_data(_('Vault Credential'), info[:vault_credential])) - rows.push(row_data(_('Vault Credential'), info[:vault_credential])) rows.push(row_data(_('Cloud Credential'), info[:cloud_credential])) rows.push(row_data(_('Max TTL (mins)'), record.config_info[type][:execution_ttl])) rows.push(row_data(_('Hosts'), record.config_info[type][:hosts])) diff --git a/app/javascript/components/ansible-playbook-edit-catalog-form/schema.js b/app/javascript/components/ansible-playbook-edit-catalog-form/schema.js index a53d410fccb..4069ac86389 100644 --- a/app/javascript/components/ansible-playbook-edit-catalog-form/schema.js +++ b/app/javascript/components/ansible-playbook-edit-catalog-form/schema.js @@ -163,8 +163,8 @@ const provisionTabSchema = ( }, { component: componentTypes.SELECT, - id: 'config_info.provision.vault_credentials', - name: 'config_info.provision.vault_credentials', + id: 'config_info.provision.vault_credential_id', + name: 'config_info.provision.vault_credential_id', label: __('Vault Credential'), options: transformGeneralOptions(vaultCredentials), condition: { @@ -371,8 +371,8 @@ const retirementTabSchema = ( }, { component: componentTypes.SELECT, - id: 'config_info.retirement.vault_credentials', - name: 'config_info.retirement.vault_credentials', + id: 'config_info.retirement.vault_credential_id', + name: 'config_info.retirement.vault_credential_id', label: __('Vault Credential'), options: transformGeneralOptions(vaultCredentials), condition: { diff --git a/app/javascript/spec/ansible-edit-catalog-form/__snapshots__/ansible-edit-catalog-form.spec.js.snap b/app/javascript/spec/ansible-edit-catalog-form/__snapshots__/ansible-edit-catalog-form.spec.js.snap index a819073e45d..f4b3fd2abcd 100644 --- a/app/javascript/spec/ansible-edit-catalog-form/__snapshots__/ansible-edit-catalog-form.spec.js.snap +++ b/app/javascript/spec/ansible-edit-catalog-form/__snapshots__/ansible-edit-catalog-form.spec.js.snap @@ -2541,10 +2541,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -3268,10 +3268,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -4758,10 +4758,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -5485,10 +5485,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -6971,10 +6971,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -7698,10 +7698,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -9180,10 +9180,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -9907,10 +9907,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -11216,10 +11216,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -11943,10 +11943,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -13263,10 +13263,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -13990,10 +13990,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -15305,10 +15305,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -16032,10 +16032,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -17367,10 +17367,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -18094,10 +18094,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -19409,10 +19409,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -20136,10 +20136,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -21462,10 +21462,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -22189,10 +22189,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -23492,10 +23492,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -24219,10 +24219,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -25525,10 +25525,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.provision.repository_id", }, - "id": "config_info.provision.vault_credentials", + "id": "config_info.provision.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.provision.vault_credentials", + "name": "config_info.provision.vault_credential_id", "options": Array [], }, Object { @@ -26252,10 +26252,10 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "isNotEmpty": true, "when": "config_info.retirement.repository_id", }, - "id": "config_info.retirement.vault_credentials", + "id": "config_info.retirement.vault_credential_id", "includeEmpty": true, "label": "Vault Credential", - "name": "config_info.retirement.vault_credentials", + "name": "config_info.retirement.vault_credential_id", "options": Array [], }, Object { @@ -40779,11 +40779,11 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie "when": "config_info.provision.repository_id", } } - id="config_info.provision.vault_credentials" + id="config_info.provision.vault_credential_id" includeEmpty={true} - key="config_info.provision.vault_credentials" + key="config_info.provision.vault_credential_id" label="Vault Credential" - name="config_info.provision.vault_credentials" + name="config_info.provision.vault_credential_id" options={Array []} > @@ -41029,8 +41029,8 @@ exports[`Ansible playbook edit catalog Form Component should not render some fie > @@ -111344,8 +111344,8 @@ exports[`Ansible playbook edit catalog Form Component should render correct form > @@ -172587,8 +172587,8 @@ exports[`Ansible playbook edit catalog Form Component should render retirement p >