New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default port for lenovo provider form to 443 #1531

Merged
merged 2 commits into from Jun 16, 2017

Conversation

Projects
None yet
3 participants
@rodneyhbrown7
Contributor

rodneyhbrown7 commented Jun 12, 2017

Pre-fills the provider form for adding a Lenovo provider to use the API port 443. See screenshot. User may continue with the default or if they have configured Xclarity with a custom port they may modify.

image

@miq-bot add_label compute/physical infrastructure, enhancement, graphics

@miq-bot

This comment has been minimized.

Show comment
Hide comment
@miq-bot

miq-bot Jun 15, 2017

Member

Checked commits https://github.com/lenovo/manageiq-ui-classic/compare/ac4fbed22e9a79af977012371e080c4a072ad2b3~...4be4927051432d0c8cf88acb1193fbd15ac561ff with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐️

Member

miq-bot commented Jun 15, 2017

Checked commits https://github.com/lenovo/manageiq-ui-classic/compare/ac4fbed22e9a79af977012371e080c4a072ad2b3~...4be4927051432d0c8cf88acb1193fbd15ac561ff with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐️

@rodneyhbrown7

This comment has been minimized.

Show comment
Hide comment
@rodneyhbrown7

rodneyhbrown7 Jun 15, 2017

Contributor

I updated the PR based on your review @mzazrivec. Thanks.

Contributor

rodneyhbrown7 commented Jun 15, 2017

I updated the PR based on your review @mzazrivec. Thanks.

@mzazrivec mzazrivec merged commit 5eaf744 into ManageIQ:master Jun 16, 2017

3 checks passed

Hakiri No security warnings were found.
Details
codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment