New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VM quadicon display #1537

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
5 participants
@hayesr
Contributor

hayesr commented Jun 13, 2017

Reverts a change to the logic that chooses the quadicon builder method. The change causes most VM-types to be rendered using the single_quad method.

Before
screen shot 2017-06-13 at 4 44 47 pm

After
screen shot 2017-06-13 at 4 43 39 pm

/cc @h-kataria @epwinchell

Reverts a change to the logic that chooses the quadicon builder metho…
…d. The change causes most VM-types to be rendered using the single_quad method.
@miq-bot

This comment has been minimized.

Show comment
Hide comment
@miq-bot

miq-bot Jun 13, 2017

Member

Checked commit hayesr@8b34171 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

Member

miq-bot commented Jun 13, 2017

Checked commit hayesr@8b34171 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@hayesr

This comment has been minimized.

Show comment
Hide comment
@hayesr

hayesr Jun 14, 2017

Contributor

Restart CI

Contributor

hayesr commented Jun 14, 2017

Restart CI

@hayesr hayesr closed this Jun 14, 2017

@hayesr hayesr reopened this Jun 14, 2017

@epwinchell

This comment has been minimized.

Show comment
Hide comment
@epwinchell

epwinchell Jun 14, 2017

Member

@hayesr I'm seeing some quads when "Show VM Quadrants" is set to "No"

screen shot 2017-06-14 at 2 24 49 pm

Member

epwinchell commented Jun 14, 2017

@hayesr I'm seeing some quads when "Show VM Quadrants" is set to "No"

screen shot 2017-06-14 at 2 24 49 pm

@hayesr

This comment has been minimized.

Show comment
Hide comment
@hayesr

hayesr Jun 14, 2017

Contributor

@epwinchell Do you have MiqTemplate quads off as well?

Contributor

hayesr commented Jun 14, 2017

@epwinchell Do you have MiqTemplate quads off as well?

@epwinchell

This comment has been minimized.

Show comment
Hide comment
@epwinchell

epwinchell Jun 14, 2017

Member

@epwinchell Do you have MiqTemplate quads off as well?

@hayesr They look fine.

Member

epwinchell commented Jun 14, 2017

@epwinchell Do you have MiqTemplate quads off as well?

@hayesr They look fine.

@epwinchell

This comment has been minimized.

Show comment
Hide comment
@epwinchell

epwinchell Jun 14, 2017

Member

@h-kataria My observation was unrelated to this PR. Looks good.

Member

epwinchell commented Jun 14, 2017

@h-kataria My observation was unrelated to this PR. Looks good.

@hayesr

This comment has been minimized.

Show comment
Hide comment
@hayesr

hayesr Jun 15, 2017

Contributor

restart CI

Contributor

hayesr commented Jun 15, 2017

restart CI

@hayesr hayesr closed this Jun 15, 2017

@hayesr hayesr reopened this Jun 15, 2017

@h-kataria h-kataria merged commit fa8751d into ManageIQ:master Jun 15, 2017

3 checks passed

Hakiri No security warnings were found.
Details
codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment