Drop the vnc_port start, end and range from the codebase

[skateman]

This seems like dead code to me, so ✂️ 🗑️ ✂️ 🔥 ✂️ 🚽

@martinpovolny and @agrare can you confirm?

https://bugzilla.redhat.com/show_bug.cgi?id=1514594

[himdel]

Not quite sure, but looks like this is used in

manageiq-providers-vmware/app/models/manageiq/providers/vmware/infra_manager/host.rb

  def reserve_next_available_vnc_port
    port_start = ext_management_system.try(:host_default_vnc_port_start).try(:to_i) || 5900
    port_end   = ext_management_system.try(:host_default_vnc_port_end).try(:to_i) || 5999

    ...

called from remote_console_vnc_acquire_ticket.

The reason I'm not as sure is that that method is called by remote_console_html5_acquire_ticket ... which is never called :) (or at least not by the full name)

[miq-bot]

Checked commit skateman@c2cb0b1 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. ⭐

[skateman]

@himdel the remote_console_html5_acquire_ticket is actually being called, using send. My problem is that these ports are never being set and according to the BZ the fields are available only when editing a provider and not when adding it. In every case when I tested this the ports weren't set and the default ones have been used.

[himdel]

Sounds like we should add the fields on adding as well :).

Maybe it may make sense to prefill them with the defualt values?

(Well, or if nobody is ever using it, drop the whole thing, even from the db, but.. do we know? :))

[skateman]

This is where @agrare or someone from the providers team could help us decide 😉

[agrare]

Hey @skateman what specifically do you need help deciding on?

[himdel]

@agrare The choice is:

• drop the fields completely, from the form, the db, etc. and just use the defaults (5900 and 5999)
• OR use the fields, add them to the new ems form, and maybe prefil them with the defaults so they're not empty.

Basically, the question is: do customers ever set it to non-default values?

[agrare]

Basically, the question is: do customers ever set it to non-default values?

I have to assume that yes, at some point, someone has set non-default values because security :)

[skateman]

Closing this PR then, will create a new one where we display the fields on a new vmware provider form too.