Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled password editing if log protocol has changed. #4885

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Hyperkid123
Copy link
Contributor

Added condition that checks protocol value. When you change auth protocol, password field is enabled by default.

bug-password

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1647013

@Hyperkid123
Copy link
Contributor Author

@miq-bot assign @h-kataria
@miq-bot add_label bug

@miq-bot
Copy link
Member

miq-bot commented Nov 7, 2018

Checked commit Hyperkid123@8c52e4a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec assigned mzazrivec and unassigned h-kataria Nov 7, 2018
@mzazrivec mzazrivec added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 7, 2018
@mzazrivec mzazrivec merged commit 1b49424 into ManageIQ:master Nov 7, 2018
simaishi pushed a commit that referenced this pull request Nov 7, 2018
Enabled password editing if log protocol has changed.

(cherry picked from commit 1b49424)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1647013
@simaishi
Copy link
Contributor

simaishi commented Nov 7, 2018

Hammer backport details:

$ git log -1
commit 48e4d7a6d25f88d3e5a0fc5a20385cec3df7be3e
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Nov 7 10:54:53 2018 +0100

    Merge pull request #4885 from Hyperkid123/fix-password-edit
    
    Enabled password editing if log protocol has changed.
    
    (cherry picked from commit 1b49424a22f1c4308fcf9e6c23839603c10ddf72)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1647013

@Hyperkid123 Hyperkid123 deleted the fix-password-edit branch November 12, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants