Deleting Code For Rename VM #7916
Conversation
MelsHyrule
force-pushed
the
rename_vm
branch
2 times, most recently
from
a4031a0
to
95d1099
Compare
@agrare Was this an oversight? Not saying we should add for this PR, but should this be added eventually? |
It's possible that VMs from Cloud providers are greyed out because they don't support rename. Are all of the VMs with this problem Cloud VMs? |
@Fryguy From what i've seen all VMs in providers are not rename-able so i'm inclined to say yes |
|
You can also hover greyed out items and it should say why in a tooltip. |
|
@Fryguy it looks like VMware is the only provider type that currently implements this feature |
|
@agrare Should we open an issue to support this across the board? Seems like something we'd want consistently. |
|
Yeah definitely, I don't see why the UI/API shouldn't have this be possible for all VM/Template types since it is guarded by |
|
Created ManageIQ/manageiq#21510 |
MelsHyrule
force-pushed
the
rename_vm
branch
4 times, most recently
from
703979a
to
ec29410
Compare
|
@miq-bot add-reviewer @Fryguy |
|
Even though this PR is correct, I feel like we should keep the mixin and only mix it into vminfra and vmcloud. In this PR the method is moved directly into vm_infra_controller.rb, but once we implement ManageIQ/manageiq#21510, then we're gonna have to update this again to add it to vm_cloud_controller.rb (and perhaps other places like template controllers). Would like @agrare's thoughts here. |
|
@Fryguy yes agreed, rename can be a valid operation for both infra and cloud type VMs |
|
Checked commits MelsHyrule/manageiq-ui-classic@4f5b0b4~...12b43c1 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
|
LGTM - @kavyanekkalapu please review. |
Fixes #7912
Renaming a VM from certain pages can cause errors.
VM Controllers to consider are: vm_controller, vm_infra_controller, vm_or_template_controller and vm_cloud_controller. However vm_or_template_controller and vm_cloud_controller handled pages do not have the option to rename their VMs so no changes needed here.
After some discussion with @agrare @Fryguy @kavyanekkalapu @chessbyte and @jrafanie we concluded that for this PR we will be removing the rename button from pages that allow for multi select, i.e. if the user wants to rename a VM they have to click into the VM's details page.
BEFORE
vm_controller page
rename.from.vm.controller.mov
Note: This is a multi selectable table. If a user selects multiple rows / VMs the rename button will be disabled.
vm_infra_controller
renaming.vm.infra.mov
Note: this page is working as. intended so we want to ensure we preserve this functionality in this PR.
Screenshots
Error after trying to rename from multi-select table
AFTER
Screen.Recording.2021-10-19.at.10.27.52.AM.mov
Screenshots
No renaming option from multi-select table
Renaming can only be done from details view
The renaming page UI
