Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PT#142772933 - power buttons vm details #635

Conversation

@AllenBW
Copy link
Member

AllenBW commented Apr 4, 2017

Refactors vmdetails state to be vmdetails component
Refactors instance rbac to align with product types
Relocates retireVM power operations to appropriate service

Adds power operatios to vmDetails component

  • obeys rbac
  • obeys power state
  • observes polling at same rate as serviceDetails

there have been visual changes in this pr...

  • bottom of vmdetails now has a bottom margin, is no longer smushed against the bottom of the screen
  • power operations now available on machine (upper right hand)
    image

just because we're here, we also added padding to catalog card view, bye bye being smushed

image

@chriskacerguis chriskacerguis self-assigned this Apr 4, 2017
@AllenBW AllenBW changed the title [WIP] PT#142772933 - power buttons vm details PT#142772933 - power buttons vm details Apr 5, 2017
@AllenBW AllenBW added fine/yes and removed wip labels Apr 5, 2017
@chriskacerguis

This comment has been minimized.

Copy link
Contributor

chriskacerguis commented Apr 5, 2017

UX change. UXD review needed.

@ManageIQ/core-ux please review.

@serenamarie125

This comment has been minimized.

Copy link

serenamarie125 commented Apr 6, 2017

Thanks for requesting review @AllenBW @chriskacerguis. I'd like to be able to verify icons before giving approval. I can do that on Friday ( we are currently going through an exercise to make VM actions and status icons consistent between RHV & Ops UI, so SUI should use the same).

@AllenBW AllenBW closed this Apr 6, 2017
@AllenBW AllenBW deleted the AllenBW:enhancement/142772933-power-buttons-vm-details branch Apr 6, 2017
@AllenBW AllenBW restored the AllenBW:enhancement/142772933-power-buttons-vm-details branch Apr 6, 2017
@AllenBW AllenBW reopened this Apr 6, 2017
AllenBW added a commit to AllenBW/manageiq-ui-service that referenced this pull request Apr 6, 2017
- removes depreciated decorator parameter from collectionsapi service
- updates supports_cockpit to suppose_launch_cockpit

TODO: update vmdetail view to update snapshots, blocked by ManageIQ#635
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Apr 6, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot miq-bot added the unmergeable label Apr 6, 2017
@AllenBW AllenBW force-pushed the AllenBW:enhancement/142772933-power-buttons-vm-details branch from 68d40ae to accf5ce Apr 6, 2017
@miq-bot miq-bot removed the unmergeable label Apr 6, 2017
@chriskacerguis

This comment has been minimized.

Copy link
Contributor

chriskacerguis commented Apr 7, 2017

@ManageIQ/core-ux reminder per your request :)

@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Apr 7, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot miq-bot added the unmergeable label Apr 7, 2017
@AllenBW

This comment has been minimized.

Copy link
Member Author

AllenBW commented Apr 10, 2017

Hi friends, working on resolving this conflict, any way we can merge this and go back and fix it once a decision has been made? A pr sitting out there this long makes me nervous... @chriskacerguis @serenamarie125

@AllenBW AllenBW force-pushed the AllenBW:enhancement/142772933-power-buttons-vm-details branch from 45bed89 to 774cb8d Apr 10, 2017
@miq-bot miq-bot removed the unmergeable label Apr 10, 2017
@chriskacerguis

This comment has been minimized.

Copy link
Contributor

chriskacerguis commented Apr 10, 2017

Can't merge without UXD review or override from John.

@serenamarie125

This comment has been minimized.

Copy link

serenamarie125 commented Apr 10, 2017

@AllenBW we are trying to come up with a proposal for common VM icons. That being said, the proposal isn't complete so this PR shouldn't be blocked. I don't think the bed should be used for retirement. Could you use what is currently being used in Ops UI for now?

@AllenBW AllenBW force-pushed the AllenBW:enhancement/142772933-power-buttons-vm-details branch from 12177ac to 85c1cce Apr 10, 2017
@AllenBW

This comment has been minimized.

Copy link
Member Author

AllenBW commented Apr 10, 2017

@serenamarie125 updated the icon to be the clock as seen here (original post has latest ss)
image

we good to merge this?

@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Apr 10, 2017

Checked commits AllenBW/manageiq-ui-service@96bfd84~...85c1cce with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@chriskacerguis

This comment has been minimized.

Copy link
Contributor

chriskacerguis commented Apr 10, 2017

@AllenBW Travis no like you. UXD approved, so as soon as you fix that, I'll merge.

@AllenBW

This comment has been minimized.

Copy link
Member Author

AllenBW commented Apr 10, 2017

Travis just needs a few kicks, the commence 😗!

@chriskacerguis chriskacerguis merged commit a5661fb into ManageIQ:master Apr 10, 2017
2 checks passed
2 checks passed
codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AllenBW AllenBW deleted the AllenBW:enhancement/142772933-power-buttons-vm-details branch Apr 10, 2017
simaishi added a commit that referenced this pull request Apr 11, 2017
…ons-vm-details

PT#142772933 -  power buttons vm details
(cherry picked from commit a5661fb)
@simaishi

This comment has been minimized.

Copy link
Contributor

simaishi commented Apr 11, 2017

Fine backport details:

$ git log -1
commit 69519f8d22d827abed15c676b003ee8fc0d165d2
Author: Chris Kacerguis <chriskacerguis@users.noreply.github.com>
Date:   Mon Apr 10 10:21:33 2017 -0500

    Merge pull request #635 from AllenBW/enhancement/142772933-power-buttons-vm-details
    
    PT#142772933 -  power buttons vm details
    (cherry picked from commit a5661fb438a8ea2ea6437ffe404225d5748b8567)
@simaishi simaishi added fine/backported and removed fine/yes labels Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.