diff --git a/app/javascript/react/screens/App/App.scss b/app/javascript/react/screens/App/App.scss index 50d51a8fc3..11856b1420 100644 --- a/app/javascript/react/screens/App/App.scss +++ b/app/javascript/react/screens/App/App.scss @@ -11,3 +11,17 @@ .required-asterisk { color: $color-pf-red-100; } + +.main-scroll-container { + height: 100%; + overflow-y: auto; + overflow-x: hidden; + margin-left: -20px; + margin-right: -20px; + padding-left: 20px; + padding-right: 20px; +} + +.main-body-content { + margin-bottom: 20px; +} diff --git a/app/javascript/react/screens/App/Mappings/Mappings.js b/app/javascript/react/screens/App/Mappings/Mappings.js index 649e632ba6..be4dd5c932 100644 --- a/app/javascript/react/screens/App/Mappings/Mappings.js +++ b/app/javascript/react/screens/App/Mappings/Mappings.js @@ -176,7 +176,7 @@ class Mappings extends Component { } = this.props; return ( - +
{mappingWizardVisible && this.mappingWizard} - +
); } } diff --git a/app/javascript/react/screens/App/Mappings/components/InfrastructureMappingsList/InfrastructureMappingsList.js b/app/javascript/react/screens/App/Mappings/components/InfrastructureMappingsList/InfrastructureMappingsList.js index e21c60cf81..238034990b 100644 --- a/app/javascript/react/screens/App/Mappings/components/InfrastructureMappingsList/InfrastructureMappingsList.js +++ b/app/javascript/react/screens/App/Mappings/components/InfrastructureMappingsList/InfrastructureMappingsList.js @@ -180,7 +180,7 @@ class InfrastructureMappingsList extends React.Component { {renderActiveFilters(filteredSortedPaginatedListItems)} -
+
{filteredSortedPaginatedListItems.items.map(mapping => { const associatedPlansCount = mapping.service_templates && mapping.service_templates.length; diff --git a/app/javascript/react/screens/App/Overview/Overview.js b/app/javascript/react/screens/App/Overview/Overview.js index cd40817434..db82c108d3 100644 --- a/app/javascript/react/screens/App/Overview/Overview.js +++ b/app/javascript/react/screens/App/Overview/Overview.js @@ -292,20 +292,18 @@ class Overview extends React.Component { productFeatures } = this.props; + const isMainContentLoading = + !requestsWithTasksPreviouslyFetched && + !this.hasMadeInitialPlansFetch && + (isFetchingAllRequestsWithTasks || + isFetchingProviders || + isFetchingTransformationPlans || + isFetchingArchivedTransformationPlans || + isFetchingTransformationMappings); + const mainContent = ( - + {hasSufficientProviders ? ( !!transformationMappings.length || !!transformationPlans.length || !!archivedTransformationPlans.length ? ( - {this.renderAggregateDataCards()} - {mainContent} -
- ) : ( -
-
+ const overviewContent = + emptyStateVisible && !isMainContentLoading ? ( +
{this.renderAggregateDataCards()} -
-
{mainContent}
-
- ); + ) : ( +
+
+ {this.renderAggregateDataCards()} +
+
+ {mainContent} +
+
+ ); return ( - +
{overviewContent} {mappingWizardVisible && this.mappingWizard} {planWizardVisible && this.planWizard} - +
); } } diff --git a/app/javascript/react/screens/App/Plan/Plan.js b/app/javascript/react/screens/App/Plan/Plan.js index 52b6a78106..06894344c3 100644 --- a/app/javascript/react/screens/App/Plan/Plan.js +++ b/app/javascript/react/screens/App/Plan/Plan.js @@ -163,7 +163,7 @@ class Plan extends React.Component { null; return ( - +
{__('Migration')} {__('Migration Plans')} @@ -278,7 +278,7 @@ class Plan extends React.Component { } /> )} - +
); } } diff --git a/app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js b/app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js index cc2bf27988..621147ea54 100644 --- a/app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js +++ b/app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js @@ -192,7 +192,7 @@ class PlanRequestDetailList extends React.Component { )} -
+
{filteredSortedPaginatedListItems.items.map(task => ( ( {renderActiveFilters(filteredSortedPaginatedListItems)} -
+
{filteredSortedPaginatedListItems.items.map((task, n) => ( +
redirectTo(key)} unmountOnExit> @@ -28,7 +28,7 @@ class Settings extends React.Component {
- +
); } } diff --git a/app/javascript/react/screens/App/Settings/__tests__/__snapshots__/Settings.test.js.snap b/app/javascript/react/screens/App/Settings/__tests__/__snapshots__/Settings.test.js.snap index d1b12f9739..8b7d2ab020 100644 --- a/app/javascript/react/screens/App/Settings/__tests__/__snapshots__/Settings.test.js.snap +++ b/app/javascript/react/screens/App/Settings/__tests__/__snapshots__/Settings.test.js.snap @@ -1,7 +1,9 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`Settings component renders correctly 1`] = ` - +
@@ -32,5 +34,5 @@ exports[`Settings component renders correctly 1`] = `
-
+
`; diff --git a/app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsList.js b/app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsList.js index fd4a116f6b..def73ef964 100644 --- a/app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsList.js +++ b/app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsList.js @@ -43,7 +43,7 @@ const ConversionHostsList = ({ {renderActiveFilters(filteredSortedPaginatedListItems)} -
+
{filteredSortedPaginatedListItems.items.map(listItem => { const { isTask } = listItem.meta; diff --git a/app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/__snapshots__/ConversionHostsList.test.js.snap b/app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/__snapshots__/ConversionHostsList.test.js.snap index 920f0e4dd6..828c83ebfc 100644 --- a/app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/__snapshots__/ConversionHostsList.test.js.snap +++ b/app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/__tests__/__snapshots__/ConversionHostsList.test.js.snap @@ -82,13 +82,7 @@ exports[`conversion hosts list renders the inner list view correctly 1`] = `