Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warm Migration - Convert plans page list views to table structure #1025

Closed
mturley opened this issue Sep 3, 2019 · 0 comments · Fixed by #1031

Comments

@mturley
Copy link
Contributor

commented Sep 3, 2019

This is a refactor to help us prepare for the functional warm migration changes, but it affects the existing list views and can be done separately from any warm-migration-specific work.

Due to the amount of data we want to show in each list item of these views (which is about to increase further with warm migration), we will only continue to run into alignment issues like #993 unless we use HTML structure that will guarantee these columns are truly aligned as columns. The approach I am attempting is to convert the underlying nested-divs structure of these list views to <table><tr><td>, and then adjust the CSS so they still look like the existing PF3 List View design. That way we keep the visual structure we have, but we can have real column alignment for all the new data we're adding.

The downside here is that we may lose the mobile-friendly "collapsed" version of these list view items at smaller screen sizes, so we'll need to address that. Perhaps we can examine how the table cells collapse on mobile in PF4 tables, which have this behavior, or we can abstract away the structure and have the view degrade back to the original nested divs when on smaller breakpoints.

This will require some CSS review to make sure we're not doing anything dumb, since we'll be sort of breaking PF3 a bit here :)

@mturley mturley self-assigned this Sep 3, 2019

@mturley mturley added this to Backlog in v2v UI via automation Sep 3, 2019

@mturley mturley moved this from Backlog to In progress in v2v UI Sep 3, 2019

v2v UI automation moved this from In progress to Done Sep 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.