Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Shallow snapshot tests of connected components are not useful #1044
A lot of the unit tests in this repo rely on shallow-rendered snapshot tests to assert the rendered tree that results from certain props/state of a component. The utility of these tests is already debatable when they actually snapshot the rendered tree, but as part of #1030, some of those tests are now snapshotting one level up, where they only capture the props of a connected component, making them fairly meaningless.
When time allows, we should look at these way-too-shallow unit tests (most of their snapshots start with