Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with migration status messages #1045

Open
mturley opened this issue Oct 8, 2019 · 1 comment

Comments

@mturley
Copy link
Contributor

commented Oct 8, 2019

Still working with @fdupont-redhat to determine the exact fixes here, but what we're observing:

In places where a status message is looked up in an i18n table (https://github.com/ManageIQ/manageiq-v2v/blob/master/app/javascript/react/screens/App/Plan/PlanConstants.js#L22, which is used for task.message and task.options.progress.current_description), if the string coming from the API is not present in the list of expected messages, we will get one of the following instead of the actual message:

  • the string "VM migrations stalled" (probably put in place to prevent long error strings from breaking the layout)
  • a blank string.

In either case, we should:

  • stop hiding unexpected strings, and figure out the right way to display them (maybe if it could be too long it should go in a popover, or maybe we just display it as-is inline)
  • update the list of expected strings to include any new ones.

It also seems like the task.options.progress strings we use may need to instead reference task.options directly instead of the progress hash, still discussing that with @fdupont-redhat .

This bug (the blank string case) can be reproduced using the database dump named status-message-issues from my collection.

Related to BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1759062

@mturley mturley self-assigned this Oct 8, 2019
@mturley mturley added this to Backlog in v2v UI via automation Oct 8, 2019
@mturley

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

For reference, this is the current set of status messages we display for each VM in the plan details list view. Right now we display:

  • Above "Status:", task.message followed by cancellation status if present, but it is run through the i18n table and if unknown, replaced by "VM migrations stalled" (probably not desired)
  • Below that, next to "Status:", we show task.options.progress.current_description but we run it through that i18n table and if unknown, it comes out blank (bug)
  • In the popover next to "Status Detail:", we show task.options.progress.states[task.options.progress.current_state].message
@mturley mturley added bz and removed bugzilla needed labels Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2v UI
  
Backlog
1 participant
You can’t perform that action at this time.