Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BZ#1775385] Mapping Wizard: OSP conversion host warning check is too broad, needs to look at specific providers #1069

Open
mturley opened this issue Nov 21, 2019 · 1 comment
Projects

Comments

@mturley
Copy link
Contributor

@mturley mturley commented Nov 21, 2019

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1775385

When we implemented OSP target support, we made a mistake (in #812) in the logic that detects whether the user needs to be warned that there is no conversion host configured.

Currently, if there are no OSP conversion hosts anywhere the appliance can find, the UI displays a warning on the clusters step of the wizard reading "No OpenStack conversion hosts are configured. You can continue to create an infrastructure mapping, but you must configure a conversion host before migration execution."

However, this warning just checks whether OSP conversion hosts exist at all, it does not take into account which provider/EMS they reside in. If the user has more than one OSP provider configured, they could in theory have a conversion host in provider A (and therefore not see the warning), but create a mapping to provider B which would fail.

The conversion host warning for OSP needs to be similar to the one for RHV (a warning icon on each target cluster in the list), but instead of looking for the conversion host in that specific target cluster/project, it should look for a conversion host with the same EMS id as that target cluster/project.

@mturley mturley added this to Backlog in v2v UI via automation Nov 21, 2019
@mturley mturley added bz and removed bugzilla needed labels Nov 21, 2019
@mturley mturley changed the title Mapping Wizard: OSP conversion host warning check is too broad, needs to look at specific providers [BZ#1775385] Mapping Wizard: OSP conversion host warning check is too broad, needs to look at specific providers Nov 21, 2019
@mturley

This comment has been minimized.

Copy link
Contributor Author

@mturley mturley commented Nov 21, 2019

Per discussion with @vconzola, the warning messages on each target cluster/project should be updated when we fix this:

For OSP: "You must enable at least one conversion host in the target provider. You can continue to create an infrastructure mapping that includes this project, but you must enable a conversion host before running the migration plan."
For RHV: "You must enable at least one conversion host in the target cluster. You can continue to create an infrastructure mapping that includes this cluster, but you must enable a conversion host before running the migration plan."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2v UI
  
Backlog
1 participant
You can’t perform that action at this time.