Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove gettext catalogs #1027

Merged

Conversation

@mzazrivec
Copy link
Contributor

commented Sep 6, 2019

  • the translations now live in core repo only
  • we don't need these files in plugins at all
  • also remove gettext initialization from the plugin (it's not needed now)

@mzazrivec mzazrivec requested a review from mturley Sep 6, 2019

@miq-bot

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Checked commits mzazrivec/miq_v2v_ui_plugin@f634867~...249f3b3 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Rubocop - missing config files
@mturley

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

Thanks for cleaning this up @mzazrivec !
If you have the time, would you mind looking at this same stuff in cfme-migration_analytics? I'm not even sure if I set up gettext correctly there in the first place anyway.

@mturley
mturley approved these changes Sep 6, 2019

@mturley mturley merged commit 8619e13 into ManageIQ:master Sep 6, 2019

3 checks passed

Hakiri No security warnings were found.
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mzazrivec mzazrivec deleted the mzazrivec:completely_remove_gettext_catalogs branch Sep 6, 2019

@mzazrivec

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

If you have the time, would you mind looking at this same stuff in cfme-migration_analytics? I'm not even sure if I set up gettext correctly there in the first place anyway.

Yes sir, it's in my TODO list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.