Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduledTimeInfoItem: fix PropType for migrationScheduled #1067

Merged

Conversation

@mzazrivec
Copy link
Contributor

mzazrivec commented Nov 20, 2019

  1. Have a failed migration plan
  2. Re-schedule it
  3. Observe the following js error:
miq_debug.self-1351f771c2cd2fab0d83069fd3f62aadbb7effc11a01ed4942f52308793453be.js?body=1:30 Warning: Failed prop type: Invalid prop `migrationScheduled` of type `string` supplied to `ScheduledTimeInfoItem`, expected `number`.
    in ScheduledTimeInfoItem (created by ListViewToolbar)
    in ListViewToolbar (created by MigrationsCompletedList)
    in Spinner (created by MigrationsCompletedList)
    in div (created by Col)
    in Col (created by MigrationsCompletedList)
    in MigrationsCompletedList (created by Migrations)
    in div (created by Migrations)
    in Migrations (created by Overview)
    in Spinner (created by Overview)
    in div (created by Overview)
    in div (created by Overview)
    in Overview (created by ConnectFunction)
    in ConnectFunction (created by I18nProviderWrapper(Connect(Overview)))
    in IntlProvider (created by I18nProviderWrapper(Connect(Overview)))
    in I18nProviderWrapper(Connect(Overview)) (created by Route)
    in Route (created by Routes)
    in Routes (created by App)
    in Router (created by ConnectedRouter)
    in ConnectedRouter (created by Context.Consumer)
    in ConnectedRouterWithContext (created by ConnectFunction)
    in ConnectFunction (created by App)
    in App (created by ConnectFunction)
    in ConnectFunction
    in Provider
@mzazrivec mzazrivec added the bug label Nov 20, 2019
@mzazrivec mzazrivec requested a review from mturley Nov 20, 2019
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Nov 20, 2019

Checked commit mzazrivec@6fcb42d with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Contributor

mturley left a comment

Thanks!

@mturley mturley merged commit 6368df3 into ManageIQ:master Nov 20, 2019
3 checks passed
3 checks passed
Hakiri No security warnings were found.
Details
codeclimate 1 fixed issue
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mzazrivec mzazrivec deleted the mzazrivec:fix_data_type_for_migration_scheduled branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.