Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of PropTypes.oneOfType #1071

Merged
merged 1 commit into from Nov 26, 2019
Merged

Conversation

@mturley
Copy link
Contributor

mturley commented Nov 25, 2019

When I reviewed #1067 I missed the new warning that appeared:

Warning: Invalid argument supplied to oneOfType, expected an instance of array.

I always forget that PropTypes.oneOfType takes an array, this PR fixes it. Sorry @mzazrivec

@mturley mturley added the bug label Nov 25, 2019
@mturley mturley requested a review from mzazrivec Nov 25, 2019
@mturley mturley added this to In progress in v2v UI via automation Nov 25, 2019
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Nov 25, 2019

Checked commit mturley@f77569a with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec

This comment has been minimized.

Copy link
Contributor

mzazrivec commented Nov 26, 2019

Ah, my bad, thanks Mike. Merging.

@mzazrivec mzazrivec self-assigned this Nov 26, 2019
@mzazrivec mzazrivec merged commit 9eff281 into ManageIQ:master Nov 26, 2019
3 checks passed
3 checks passed
Hakiri No security warnings were found.
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
v2v UI automation moved this from In progress to Done Nov 26, 2019
@mturley mturley deleted the mturley:proptypes-syntax branch Nov 26, 2019
@mturley

This comment has been minimized.

Copy link
Contributor Author

mturley commented Nov 26, 2019

No worries, it was my mistake in the code snippet I sent you and in my review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2v UI
  
Done
3 participants
You can’t perform that action at this time.