Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add popup for warm migrations #1075

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@mzazrivec
Copy link
Contributor

mzazrivec commented Dec 3, 2019

In case some of the selected VMs can't be pre-copied, the plan creation wizard would disable the warm migration option and render an icon with a popover text.

Warm migration is possible:
warm-wizard-01

Warm migration is not possible (with the warm radio button disabled):
warm-wizard-02

Popup:
warm-wizard-03

@miq-bot miq-bot added the wip label Dec 3, 2019
@mzazrivec mzazrivec force-pushed the mzazrivec:add_popup_for_warm_migrations branch 4 times, most recently from 9e40cfe to b212428 Dec 3, 2019
@mzazrivec mzazrivec changed the title [WIP] Add popup for warm migrations Add popup for warm migrations Dec 4, 2019
@mzazrivec mzazrivec removed the wip label Dec 4, 2019
@mzazrivec mzazrivec force-pushed the mzazrivec:add_popup_for_warm_migrations branch from b212428 to 46bf902 Dec 5, 2019
@mzazrivec mzazrivec requested a review from mturley Dec 5, 2019
@@ -13,14 +18,20 @@ export const PlanWizardScheduleStep = ({ targetProvider, migration_plan_type_rad
label={__('Migration Type')}
inline_label={false}
controlWidth={12}
info={

This comment has been minimized.

Copy link
@mturley

mturley Dec 5, 2019

Contributor

This info icon should instead be a warning icon (https://github.com/ManageIQ/manageiq-v2v/blob/master/app/javascript/react/screens/App/common/forms/FormField.js#L92 should render name="warning-triangle-o" on that Icon), so we probably need to add a prop like infoIconName to FormField that defaults to 'info' but can be overridden here.

This comment has been minimized.

Copy link
@mzazrivec

mzazrivec Dec 6, 2019

Author Contributor

Yes sir, fixed & updated the screenshots as well.

@mzazrivec mzazrivec force-pushed the mzazrivec:add_popup_for_warm_migrations branch from 46bf902 to aab6fa0 Dec 6, 2019
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Dec 6, 2019

Checked commit mzazrivec@aab6fa0 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mturley
mturley approved these changes Dec 6, 2019
Copy link
Contributor

mturley left a comment

LGTM 👍

@mturley mturley merged commit 2ac3dd8 into ManageIQ:master Dec 6, 2019
2 of 3 checks passed
2 of 3 checks passed
codeclimate 3 issues to fix
Details
Hakiri No security warnings were found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mturley mturley added the ivanchuk/yes label Dec 6, 2019
@mturley mturley added this to In progress in v2v UI via automation Dec 6, 2019
@mzazrivec mzazrivec deleted the mzazrivec:add_popup_for_warm_migrations branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2v UI
  
In progress
3 participants
You can’t perform that action at this time.