Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Roll back to previously locked versions of packages that are causing test failures #1083
When @mzazrivec mentioned the CI failures in #1082 (comment) I noticed many of them were unrelated to the code changes in that PR. I realized that since we removed
The failures were related to:
This PR reverts those packages to the specific versions that were locked in the
We should possibly eventually upgrade these packages and make the code changes necessary to make the tests pass with the new versions, but I didn't think our CI should fail just because something outside the repo changed. We can make those changes when we're ready to.
I'm also trusting (hoping) that all the other packages we are now pulling in newer versions of are honoring their semantic versioning and not releasing any breaking changes that we'll get with this package.json, and that this kind of thing will only break unit tests that assume the lack of new features. I really hope I'm right about that.. maybe we should be avoiding the
This will unblock all other open PRs, which should be rebased on these changes.