Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for deleting warm migration cutover date #1095

Merged

Conversation

@mzazrivec
Copy link
Contributor

mzazrivec commented Jan 24, 2020

New kebab menu item for deletion
delete-cutover-01

Confirmation dialog
delete-cutover-02

This needs to be tested with ManageIQ/manageiq#19759 in place

</React.Fragment>
);

const confirmModalProps = {

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot Jan 24, 2020

Similar blocks of code found in 2 locations. Consider refactoring.

@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Jan 24, 2020

Checked commit mzazrivec@453a5b5 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐️

@mzazrivec

This comment has been minimized.

Copy link
Contributor Author

mzazrivec commented Feb 4, 2020

@mturley the backend part for this has already been merged, so I guess this one is ready for review. Thanks!

@mturley
mturley approved these changes Feb 4, 2020
Copy link
Contributor

mturley left a comment

LGTM 👍

@mturley mturley merged commit 5d480ac into ManageIQ:master Feb 4, 2020
2 of 3 checks passed
2 of 3 checks passed
codeclimate 5 issues to fix
Details
Hakiri No security warnings were found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mzazrivec mzazrivec deleted the mzazrivec:add_deletion_of_warm_migration_cutover branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.