Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render loop in Conversion Host wizard caused by validation workaround #1103

Merged
merged 2 commits into from Feb 7, 2020

Conversation

@mturley
Copy link
Contributor

mturley commented Feb 7, 2020

Fixes #1089. See explanation here: #1089 (comment)

@mturley mturley added bug UI labels Feb 7, 2020
@mturley mturley requested a review from mzazrivec Feb 7, 2020
@mturley mturley added this to In progress in v2v UI via automation Feb 7, 2020
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Feb 7, 2020

Checked commits mturley/manageiq-v2v@21651a9~...f6faa67 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec

This comment has been minimized.

Copy link
Contributor

mzazrivec commented Feb 7, 2020

I tested this and I can confirm that it fixes the issue. I can also merge it, though I'd also like to give @himdel a chance to chime in here, since he was involved in this as well.

@mzazrivec

This comment has been minimized.

Copy link
Contributor

mzazrivec commented Feb 7, 2020

After a discussion with @himdel I'm merging this.

@mzazrivec mzazrivec merged commit b25cd7e into ManageIQ:master Feb 7, 2020
3 checks passed
3 checks passed
Hakiri No security warnings were found.
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
v2v UI automation moved this from In progress to Done Feb 7, 2020
@mturley mturley deleted the mturley:1089-fix-validation-workaround branch Feb 7, 2020
@mturley

This comment has been minimized.

Copy link
Contributor Author

mturley commented Feb 7, 2020

Thanks guys 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2v UI
  
Done
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.