This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
[#1069] [BZ#1775385] Mapping Wizard: Fix OSP conversion host check to be more strict #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturley
added
bug
bz
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
...nts/MappingWizardClustersStep/components/ClustersStepForm/__tests__/ClustersStepForm.test.js
Show resolved
Hide resolved
...nts/MappingWizardClustersStep/components/ClustersStepForm/__tests__/ClustersStepForm.test.js
Show resolved
Hide resolved
...gWizard/components/MappingWizardClustersStep/components/ClustersStepForm/ClustersStepForm.js
Show resolved
Hide resolved
|
Checked commits mturley/manageiq-v2v@85a7353~...02745a1 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint |
mzazrivec
approved these changes
Feb 19, 2020
|
This PR effectively fixes #1107 |
simaishi
pushed a commit
that referenced
this pull request
Feb 24, 2020
[#1069] [BZ#1775385] Mapping Wizard: Fix OSP conversion host check to be more strict (cherry picked from commit a879780) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1805910
|
Ivanchuk backport details: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1069
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1775385
In the case where the user has more than one OpenStack provider configured, but only has conversion hosts configured in one of them, the mapping wizard was not able to warn them that migrations to the provider with no conversion hosts would fail (it only showed a warning if there were no OSP conversion hosts anywhere).
This PR moves the alert from a wizard-level inline alert into individual alert icons next to each target project (just like RHV conversion host warnings) and appears on any project which is in a provider where there are no OSP conversion hosts.
This also updates the text of the existing RHV warning to make it consistent with the new OSP one, based on @vconzola 's copy here: #1069 (comment)