Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining warm migration UI changes (Plans and Plan Details views) #1119

Merged
merged 26 commits into from Mar 20, 2020

Conversation

@mturley
Copy link
Contributor

mturley commented Mar 20, 2020

Replacement for #1077
Closes #1023
Closes #433

Should be the final piece for https://bugzilla.redhat.com/show_bug.cgi?id=1814281.

This PR implements the remaining changes from Vince's warm migration mockups now that we have real warm migration data to test against.

I saved several database dumps from various stages of UCI-based migrations (warm and cold) from an appliance last week, which can be found here: https://drive.google.com/drive/u/1/folders/1edZSrfZvSw8jjLtuI-HEuAynKIio3hhN

From that collection, here are a few useful databases to reproduce various states of warm migrations:

  • uci-migrations-7 has a cold migration and a warm migration in progress at the same time, to demonstrate the colSpan layout. Scheduling a cutover on the warm migration shows how the cold migration progress bar spans both the pre-copy status and the cutover time info items.
  • uci-migrations-12 has a warm migration initializing.
  • uci-migrations-13 has a warm migration running its initial pre-copy (progress bar visible on the plan details page).
  • uci-migrations-20-many-copies has a warm migration with several pre-copies completed, ready for cutover but with no cutover scheduled.
  • uci-migrations-22-shutting-down has a warm migration just after cutover starts, shutting down its source VM.
  • uci-migrations-23-transforming has a warm migration mid-cutover, transforming the VM.
  • uci-migrations-27-success has a warm migration in the successfully complete state.

I don't currently have any databases with failed pre-copies, but you can test those views by modifying the return value of reduceCopies in warmMigrationHelpers.js and set finishedWithErrors to true. We don't yet have error status/messages for each pre-copy in the API, this naive error case will only occur if a pre-copy ended without copying all of its data.

This PR also rearranges some of the columns and labels on the plans not started view and the plans completed view, based on these mockups.

Screens

These were taken with database dumps about 9 days old, so disregard the durations and timestamps.

Running initial pre-copy

In the plans in progress view:
Screenshot 2020-03-19 23 01 12-plans-initial-precopy

In the plan details view (expanded):
Screenshot 2020-03-19 22 57 06-details-initial-precopy

With successful pre-copies, before cutover

In the plans in progress view (with a cold migration also running):
Screenshot 2020-03-20 00 12 12-plans-warm-and-cold-success

With a cutover scheduled, to demonstrate layout alongside cold migration:
Screenshot 2020-03-20 00 12 36-plans-warm-and-cold-w-schedule

In the plan details view (collapsed):
Screenshot 2020-03-19 21 04 02-details-several-precopies-collapsed

In the plan details view (expanded):
Screenshot 2020-03-19 21 04 08-details-several-precopies-expanded

With a failed pre-copy

In the plans in progress view:
Screenshot 2020-03-19 21 22 44-plans-precopy-failed

In the plan details view:
Screenshot 2020-03-20 00 16 46-details-precopy-failed

With a cutover in progress

In the plans in progress view:
Screenshot 2020-03-19 22 37 02-plans-cutover-in-progress

In the plan details view (collapsed):
Screenshot 2020-03-20 00 31 59

On the plans completed view

Screenshot 2020-03-19 23 44 28-completed

Minor updates to the plans not started view (for cold migrations):

Screenshot 2020-03-19 23 44 22-not-started

mturley added 26 commits Nov 12, 2019
@mturley mturley added the needs-tests label Mar 20, 2020
@mturley mturley requested a review from mzazrivec Mar 20, 2020
@mturley mturley added this to In progress in v2v UI via automation Mar 20, 2020
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Mar 20, 2020

Checked commits mturley/manageiq-v2v@8ea30ef~...4549c46 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

@mturley

This comment has been minimized.

Copy link
Contributor Author

mturley commented Mar 20, 2020

@mturley

This comment has been minimized.

Copy link
Contributor Author

mturley commented Mar 20, 2020

I expect to run into issues backporting this and some of the other warm migration PRs (#1052) so I'll open ivanchuk-specific PRs for them asap.

@mzazrivec mzazrivec merged commit 7cccd54 into ManageIQ:master Mar 20, 2020
2 of 3 checks passed
2 of 3 checks passed
codeclimate 17 issues to fix
Details
Hakiri No security warnings were found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
v2v UI automation moved this from In progress to Done Mar 20, 2020
@mturley mturley deleted the mturley:warm-migration-end-to-end branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2v UI
  
Done
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.