This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
[#1047][BZ#1760001] Fix inconsistent scrollbar behavior by removing fixed headers and just having one scroll body for each page #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t having one scroll body for each page
mturley
added
bug
bz
|
Checked commits mturley/manageiq-v2v@33dd3a9~...af89db1 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
mzazrivec
approved these changes
May 11, 2020
|
Backported to ivanchuk via #1130 |
simaishi
pushed a commit
that referenced
this pull request
May 11, 2020
[#1047][BZ#1760001] Fix inconsistent scrollbar behavior by removing fixed headers and just having one scroll body for each page (cherry picked from commit 4d797aa) https://bugzilla.redhat.com/show_bug.cgi?id=1760001
|
Jansa backport details: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1047
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1760001
In manageiq-ui-classic, the bodies of tables and list views have their height set by JavaScript when the window resizes so that they can have their own scrollbar and the breadcrumb, toolbars, and footer can be pinned outside that scrollbar.
We had tried to replicate that with CSS since we can't reuse that same window resize code (it would be overridden by React whenever our components re-rendered). The CSS solution was broken though, causing the issue in this BZ. To properly fix it would have meant restructuring the container to use proper flexbox CSS, which is difficult with the PatternFly 3 CSS (which is probably why JS was used to solve it in ui-classic) and may have had unintended consequences.
This PR simply removes the attempt to have these dynamic-height content areas, and makes each of our pages one whole scroll container. This fixes the bug in a predictable way with minimal drawback.