Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Plan Wizard Instance Properties step actions and reducer #820

Merged
merged 1 commit into from Dec 7, 2018

Conversation

@mturley
Copy link
Contributor

commented Dec 6, 2018

@mturley mturley added this to In progress in v2v UI via automation Dec 6, 2018
@mturley mturley requested a review from michaelkro Dec 6, 2018
});
});

describe('querying best fit flavors', () => {

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot Dec 6, 2018

Similar blocks of code found in 2 locations. Consider refactoring.

instancePropertiesRows
} from '../planWizardInstancePropertiesStep.fixtures';

it('sets default state', () => {

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot Dec 6, 2018

Similar blocks of code found in 6 locations. Consider refactoring.

@mturley mturley removed the bugzilla needed label Dec 7, 2018
@mturley mturley force-pushed the mturley:instance-properties-tests branch from f6e2c99 to e85532d Dec 7, 2018
@miq-bot

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

Checked commit mturley@e85532d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Contributor

left a comment

Nice! 🏆

@michaelkro michaelkro merged commit db3882a into ManageIQ:master Dec 7, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
v2v UI automation moved this from In progress to Done Dec 7, 2018
@mturley mturley deleted the mturley:instance-properties-tests branch Dec 7, 2018
@simaishi simaishi added the blocker label Dec 11, 2018
simaishi added a commit that referenced this pull request Dec 11, 2018
Add tests for Plan Wizard Instance Properties step actions and reducer

(cherry picked from commit db3882a)

https://bugzilla.redhat.com/show_bug.cgi?id=1657285
@simaishi

This comment has been minimized.

Copy link

commented Dec 11, 2018

Hammer backport details:

$ git log -1
commit 9d0ab94a87a837d12c74364e7d13254b9c9fd9f5
Author: Michael Ro <mikerodev@gmail.com>
Date:   Fri Dec 7 11:28:22 2018 -0500

    Merge pull request #820 from mturley/instance-properties-tests
    
    Add tests for Plan Wizard Instance Properties step actions and reducer
    
    (cherry picked from commit db3882ad0b41199df926ab538e82471f7e74c9cd)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1657285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2v UI
  
Done
4 participants
You can’t perform that action at this time.