Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#830] Remove passive voice in infra mapping conversion host warning #831

Merged

Conversation

@mturley
Copy link
Contributor

commented Dec 10, 2018

@mturley mturley added this to In progress in v2v UI via automation Dec 10, 2018
@mturley mturley requested a review from michaelkro Dec 10, 2018
@miq-bot

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Checked commit mturley@96967b9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@michaelkro michaelkro merged commit 9df1154 into ManageIQ:master Dec 10, 2018
2 checks passed
2 checks passed
Hakiri No security warnings were found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
v2v UI automation moved this from In progress to Done Dec 10, 2018
@mturley mturley deleted the mturley:830-mapping-warning-passive-voice branch Dec 10, 2018
@simaishi simaishi added the blocker label Dec 10, 2018
simaishi added a commit that referenced this pull request Dec 11, 2018
[#830] Remove passive voice in infra mapping conversion host warning

(cherry picked from commit 9df1154)

https://bugzilla.redhat.com/show_bug.cgi?id=1653169
@simaishi

This comment has been minimized.

Copy link

commented Dec 11, 2018

Hammer backport details:

$ git log -1
commit 79923f130aa0c58b9a93f3869738918b6972baf3
Author: Michael Ro <mikerodev@gmail.com>
Date:   Mon Dec 10 14:13:59 2018 -0500

    Merge pull request #831 from mturley/830-mapping-warning-passive-voice
    
    [#830] Remove passive voice in infra mapping conversion host warning
    
    (cherry picked from commit 9df1154f7f6bad4afefdc7755e21c380e4f99a3b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1653169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2v UI
  
Done
4 participants
You can’t perform that action at this time.