Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#794] Show a warning if OSP provider lacks RSA key #833

Merged
merged 1 commit into from Dec 11, 2018

Conversation

@michaelkro
Copy link
Contributor

commented Dec 11, 2018

Part 1 of #794

  • For all available target cloud tenants, query their OSP provider along
    with their authentications
  • If any tenant's associated provider lacks an authentication with
    authtype ssh_keypair, render the warning icon

https://bugzilla.redhat.com/show_bug.cgi?id=1650340

Notes

  • v2v-newdb-2 has an OSP provider with no RSA key pair
  • ospv2vbos has an OSP provider with a RSA key pair

Screens

manageiq__migration

@michaelkro michaelkro requested a review from mturley Dec 11, 2018
@michaelkro michaelkro added this to In progress in v2v UI via automation Dec 11, 2018
@michaelkro michaelkro changed the title Show a warning if OSP provider lacks RSA key [#794] Show a warning if OSP provider lacks RSA key Dec 11, 2018
@@ -73,6 +78,19 @@ export default (state = initialState, action) => {
.set('errorHostsQuery', action.payload)
.set('isFetchingHostsQuery', false)
.set('isRejectedHostsQuery', true);
case `${QUERY_V2V_PROVIDERS}_PENDING`:
return state.set('isQueryingProviders', true).set('isRejectedQueryProviders', false);
case `${QUERY_V2V_PROVIDERS}_FULFILLED`:

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot Dec 11, 2018

Similar blocks of code found in 8 locations. Consider refactoring.

@@ -155,3 +146,67 @@ describe('fetching target clusters', () => {
});
});
});

describe('QUERY_V2V_PROVIDERS', () => {
test('querying providers is pending', () => {

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot Dec 11, 2018

Similar blocks of code found in 2 locations. Consider refactoring.

// ****************************************************************************
// QUERY_V2V_PROVIDERS
// ****************************************************************************
const _queryProvidersActionCreator = (url, providerIds) => dispatch =>

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot Dec 11, 2018

Similar blocks of code found in 2 locations. Consider refactoring.

response: [{ mock: 'data' }]
});

return store.dispatch(actions.queryProvidersAction(url, providerIds)).then(() => {

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot Dec 11, 2018

Similar blocks of code found in 2 locations. Consider refactoring.

response: { error: 'error' }
});

return store.dispatch(actions.queryProvidersAction(url, providerIds)).catch(() => {

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot Dec 11, 2018

Similar blocks of code found in 2 locations. Consider refactoring.

* For all available target cloud tenants, query their OSP provider along
  with their authentications
* If any tenant's associated provider lacks an authentication with
  authtype ssh_keypair, render the warning icon

https://bugzilla.redhat.com/show_bug.cgi?id=1650340
@michaelkro michaelkro force-pushed the michaelkro:794-rsa-key-pair-warning branch from 0b83114 to d6adf67 Dec 11, 2018
@miq-bot

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Checked commit michaelkro@d6adf67 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

Copy link
Contributor

left a comment

Nice work! And thanks for cleaning up the constants and tests.

@mturley mturley merged commit c0c301d into ManageIQ:master Dec 11, 2018
2 checks passed
2 checks passed
Hakiri No security warnings were found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
v2v UI automation moved this from In progress to Done Dec 11, 2018
@michaelkro michaelkro deleted the michaelkro:794-rsa-key-pair-warning branch Dec 12, 2018
@simaishi simaishi added the blocker label Dec 14, 2018
simaishi added a commit that referenced this pull request Dec 14, 2018
@simaishi

This comment has been minimized.

Copy link

commented Dec 14, 2018

Hammer backport details:

$ git log -1
commit 87d120afcf206b27a5b4f12aecd42c61013e07ae
Author: Mike Turley <mike.turley@alum.cs.umass.edu>
Date:   Tue Dec 11 17:29:25 2018 -0500

    Merge pull request #833 from michaelkro/794-rsa-key-pair-warning
    
    [#794] Show a warning if OSP provider lacks RSA key
    
    (cherry picked from commit c0c301d3c943aad65c6c9c5e6c8e8b864a8af76d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1650340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2v UI
  
Done
4 participants
You can’t perform that action at this time.