Fix provider service model inheritance

Discovered ConfigurationManager and ProvisioningManager service models were not properly converted to pluggable provider name-spacing. https://bugzilla.redhat.com/show_bug.cgi?id=1280350
ManageIQ · Nov 16, 2015 · e2b18ef · e2b18ef
1 parent 92ff2c3
commit e2b18ef
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/...s/miq_ae_service_configuration_manager.rb → ...nageiq-providers-configuration_manager.rb b/...s/miq_ae_service_configuration_manager.rb → ...nageiq-providers-configuration_manager.rb
@@ -1,5 +1,5 @@
 module MiqAeMethodService
-  class MiqAeServiceConfigurationManager < MiqAeServiceModelBase
+  class MiqAeServiceManageIQ_Providers_ConfigurationManager < MiqAeServiceExtManagementSystem
     expose :provider,               :association => true
     expose :configuration_profiles, :association => true
     expose :configured_systems,     :association => true

diff --git a/...ls/miq_ae_service_provisioning_manager.rb → ...anageiq-providers-provisioning_manager.rb b/...ls/miq_ae_service_provisioning_manager.rb → ...anageiq-providers-provisioning_manager.rb
@@ -1,5 +1,5 @@
 module MiqAeMethodService
-  class MiqAeServiceProvisioningManager < MiqAeServiceModelBase
+  class MiqAeServiceManageIQ_Providers_ProvisioningManager < MiqAeServiceExtManagementSystem
     expose :provider,                 :association => true
     expose :operating_system_flavors, :association => true
     expose :customization_scripts,    :association => true

diff --git a/spec/lib/miq_automation_engine/miq_ae_service_spec.rb b/spec/lib/miq_automation_engine/miq_ae_service_spec.rb
@@ -78,6 +78,12 @@ module MiqAeServiceSpec
       it "raises error on invalid service_model name" do
         expect { miq_ae_service.service_model(:invalid_model) }.to raise_error(NameError)
       end
+
+      it "loads all mapped models" do
+        MiqAeMethodService::MiqAeService::LEGACY_MODEL_NAMES.values.each do |model_name|
+          expect { "MiqAeMethodService::MiqAeService#{model_name}".constantize }.to_not raise_error
+        end
+      end
     end
   end
 end