Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure -> Tasks "Per Page" pulldown doesn't do anything #818

Closed
jrafanie opened this issue Oct 13, 2014 · 8 comments
Closed

Configure -> Tasks "Per Page" pulldown doesn't do anything #818

jrafanie opened this issue Oct 13, 2014 · 8 comments
Assignees
Labels

Comments

@jrafanie
Copy link
Member

Verified on chrome and firefox.

When you visit "my vm analysis tasks" or others in this section, the per page pulldown on both the top and bottom show 50:

screen shot 2014-10-13 at 4 10 27 pm

If I change the top pulldown to 5:

screen shot 2014-10-13 at 4 10 48 pm

3 issues:

  • It still shows 50 items in the table content
  • It still shows 1-50 of 126 next to the changed pulldown
  • The bottom pulldown still shows the 50 in the pulldown, see below

screen shot 2014-10-13 at 4 10 57 pm

@dclarizio
Copy link

@mzazrivec Please test this in 5.3 and if it is also present there, open BZs for both 5.3.z target and 5.4 target. Thx, Dan

@jrafanie
Copy link
Member Author

jrafanie commented Dec 2, 2014

@mzazrivec bump, can you see if this is still an issue? The tasks page was pretty hard to use with this bug.

@mzazrivec
Copy link
Contributor

@jrafanie Yup, I was able to reproduce this problem just fine. Matter of fact, I'm working
on a fix for this right now. Though the problematic routine / method affects multiple pages
in our app, so the fix isn't going to be as easy as I thought ...

@jrafanie
Copy link
Member Author

jrafanie commented Dec 3, 2014

🍪 Thanks @mzazrivec

@mzazrivec
Copy link
Contributor

I have a fix for this problem ready & working, though there's another (related) problem
showing on this page.

  1. You hit the refresh button -> the page refreshes
  2. You try to navigate the pages in the rendered list, though this finishes with an ISE:

Started GET "/miq_proxy/button?page=2&pressed=miq_task_reload"
ActionController::RoutingError (No route matches [GET] "/miq_proxy/button")
...

The routing error here is a bit miselading. We're not missing a route here, but the list view
is set to make incorrect request here. Correctly, it should be doing

GET /miq_proxy/change_tab?page=2&tab=2

@mzazrivec
Copy link
Contributor

Actually, after looking closely at the problem described in the previous comment
it seems that this is not just a problem of this parciular page, but a general problem
of all list that have a refresh button.

I'll be opening a separate issue for this.

@mzazrivec
Copy link
Contributor

I reported the bug described in last comments as a separate issue #1182

@mzazrivec
Copy link
Contributor

I believe this issue should be now closed, the problem described here has been
addressed with pull request #1231

@Fryguy Fryguy added this to the Sprint 17 Ending Jan 5, 2015 milestone Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants