Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upLaunch an URL returned by an automate button #10118
Conversation
martinpovolny
added
enhancement
ui
labels
Jul 28, 2016
chessbyte
added
the
wip
label
Jul 28, 2016
chessbyte
assigned
mkanoor
Jul 28, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
gmcculloug
Jul 28, 2016
Member
We do something like this for the Dynamic dialog fields in automate. We run an automate resolution and get a workspace back app/models/dynamic_dialog_field_value_processor.rb#L8. Then pass the root attributes app/models/dynamic_dialog_field_value_processor.rb#L14 to be processed here app/models/dialog_field_text_box.rb#L61.
Does that help?
|
We do something like this for the Dynamic dialog fields in automate. We run an automate resolution and get a workspace back app/models/dynamic_dialog_field_value_processor.rb#L8. Then pass the root attributes app/models/dynamic_dialog_field_value_processor.rb#L14 to be processed here app/models/dialog_field_text_box.rb#L61. Does that help? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
martinpovolny
Jul 29, 2016
Contributor
@gmcculloug : If I read it correctly, then that is sync. I need to do it async through the MiqTask (and wait_for_task on the UI side).
Things like setting up a tunnel might take some time and the UI should not hang while waiting for the automate.
Also the setup of a tunnel to a VNC endpoint on a hypevisor node would be done by a different appliance. The UI appliance probably won't be able to reach the hypervisor nodes directly at a service provider deployment.
Does that make sense?
|
@gmcculloug : If I read it correctly, then that is sync. I need to do it async through the MiqTask (and wait_for_task on the UI side). Things like setting up a tunnel might take some time and the UI should not hang while waiting for the automate. Also the setup of a tunnel to a VNC endpoint on a hypevisor node would be done by a different appliance. The UI appliance probably won't be able to reach the hypervisor nodes directly at a service provider deployment. Does that make sense? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
gmcculloug
Aug 1, 2016
Member
@martinpovolny I think what you really want to do here is pass something to the automate method that it can update instead of trying to pull back data from the automate method.
For example you could pass the ID of the resource you are running against and if that supports custom_attributes the automate script could set the required data there. Otherwise, we could do something like expose the MiqTask object to the automate service model and allow the automate method to set values into the Task.
|
@martinpovolny I think what you really want to do here is pass something to the automate method that it can update instead of trying to pull back data from the automate method. For example you could pass the ID of the resource you are running against and if that supports custom_attributes the automate script could set the required data there. Otherwise, we could do something like expose the MiqTask object to the automate service model and allow the automate method to set values into the Task. |
gmcculloug
reviewed
Sep 12, 2016
View changes
lib/miq_automation_engine/service_models/miq_ae_service_vm_infra.rb Outdated
martinpovolny
removed
the
wip
label
Sep 22, 2016
martinpovolny
changed the title from
[WIP] Launch an URL returned by an automate button
to
Launch an URL returned by an automate button
Sep 22, 2016
martinpovolny
changed the title from
Launch an URL returned by an automate button
to
[WIP] Launch an URL returned by an automate button
Sep 22, 2016
martinpovolny
added
the
wip
label
Sep 22, 2016
martinpovolny
changed the title from
[WIP] Launch an URL returned by an automate button
to
Launch an URL returned by an automate button
Oct 17, 2016
martinpovolny
removed
the
wip
label
Oct 17, 2016
app/controllers/application_controller/buttons.rb Outdated
martinpovolny
added
the
euwe/yes
label
Oct 21, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
skateman
Oct 23, 2016
Member
@martinpovolny I'm getting this error in the automate.log:
[----] E, [2016-10-23T21:58:05.450688 #24350:2b16aae6f550] ERROR -- : MiqAeServiceModelBase.ar_method raised: <ActiveRecord::RecordInvalid>: <Validation failed: Url secret has already been taken>
[----] E, [2016-10-23T21:58:05.450768 #24350:2b16aae6f550] ERROR -- : /home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/validations.rb:78:in `raise_validation_error'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/validations.rb:50:in `save!'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/attribute_methods/dirty.rb:30:in `save!'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/transactions.rb:324:in `block in save!'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/transactions.rb:395:in `block in with_transaction_returning_status'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `block in transaction'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract/transaction.rb:189:in `within_new_transaction'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `transaction'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/transactions.rb:211:in `transaction'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/transactions.rb:392:in `with_transaction_returning_status'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/transactions.rb:324:in `save!'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/suppressor.rb:45:in `save!'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activerecord-5.0.0.1/lib/active_record/persistence.rb:51:in `create!'
/home/dhalasz/Repositories/ManageIQ/manageiq/app/models/vm.rb:97:in `set_remote_console_url'
/home/dhalasz/Repositories/ManageIQ/manageiq/lib/miq_automation_engine/engine/miq_ae_service_model_base.rb:269:in `public_send'
/home/dhalasz/Repositories/ManageIQ/manageiq/lib/miq_automation_engine/engine/miq_ae_service_model_base.rb:269:in `block in object_send'
/home/dhalasz/Repositories/ManageIQ/manageiq/lib/miq_automation_engine/engine/miq_ae_service_model_base.rb:288:in `ar_method'
/home/dhalasz/Repositories/ManageIQ/manageiq/lib/miq_automation_engine/engine/miq_ae_service_model_base.rb:298:in `ar_method'
/home/dhalasz/Repositories/ManageIQ/manageiq/lib/miq_automation_engine/engine/miq_ae_service_model_base.rb:267:in `object_send'
/home/dhalasz/Repositories/ManageIQ/manageiq/lib/miq_automation_engine/engine/miq_ae_service_model_base.rb:122:in `block (2 levels) in expose'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/2.3.0/drb/drb.rb:1624:in `perform_without_block'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/2.3.0/drb/drb.rb:1584:in `perform'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/2.3.0/drb/drb.rb:1657:in `block (2 levels) in main_loop'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/2.3.0/drb/drb.rb:1653:in `loop'
/home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/2.3.0/drb/drb.rb:1653:in `block in main_loop'
[----] E, [2016-10-23T21:58:05.455019 #24350:2b16ac1643a4] ERROR -- : <AEMethod openurl> The following error occurred during method evaluation:
[----] E, [2016-10-23T21:58:05.455498 #24350:2b16ac1643a4] ERROR -- : <AEMethod openurl> DRb::DRbUnknownError: ActiveRecord
[----] E, [2016-10-23T21:58:05.456382 #24350:2b16ac1643a4] ERROR -- : <AEMethod openurl> /home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/2.3.0/drb/drb.rb:1149:in `method_missing'
[----] E, [2016-10-23T21:58:05.459874 #24350:2b16ac1643a4] ERROR -- : Method STDERR: /home/dhalasz/.rbenv/versions/2.3.1/lib/ruby/2.3.0/drb/drb.rb:1149:in `method_missing': ActiveRecord (DRb::DRbUnknownError)
[----] E, [2016-10-23T21:58:05.460288 #24350:2b16ac1643a4] ERROR -- : Method STDERR: from <code: $evm.root['vm'].set_remote_console_url(:url => 'http://www.seznam.cz', :userid => $evm.root['user_id'])>:5:in `<main>'
[----] I, [2016-10-23T21:58:05.465484 #24350:2b16aae5b104] INFO -- : <AEMethod [/miq-Marketplace/System/Request/OpenURL]> Ending
|
@martinpovolny I'm getting this error in the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@skateman : can you, please, check again? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
skateman
Oct 25, 2016
Member
@martinpovolny looks good, aren't we planning to add a spinner while we wait for the task?
|
@martinpovolny looks good, aren't we planning to add a spinner while we wait for the task? |
mkanoor
assigned
gmcculloug
Oct 25, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
martinpovolny
Oct 25, 2016
Contributor
Would be good to get some feedback from the automate people.
I think that the functionality is a good one but I am not so sure about how I actually did it. It works but if feels hacky.
The question by @mkanoor if it's only valid for VMs suggests it might make sense for more entities. But the SystemConsole model is only related to VMs.
|
Would be good to get some feedback from the automate people. I think that the functionality is a good one but I am not so sure about how I actually did it. It works but if feels hacky. The question by @mkanoor if it's only valid for VMs suggests it might make sense for more entities. But the |
spec/models/vm_spec.rb Outdated
app/models/vm.rb Outdated
app/models/vm.rb Outdated
lib/miq_automation_engine/service_models/miq_ae_service_vm.rb Outdated
app/controllers/application_controller/buttons.rb Outdated
lib/miq_automation_engine/service_models/miq_ae_service_vm.rb Outdated
app/models/vm.rb Outdated
martinpovolny
added some commits
Jul 28, 2016
martinpovolny
added some commits
Oct 31, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
miq-bot
Nov 27, 2016
Member
<github_pr_commenter_batch />Some comments on commits martinpovolny/manageiq@c9de5ff~...c02e8ea
spec/controllers/application_controller/buttons_spec.rb
-
⚠️ - 55 - Detectedexpect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
|
<github_pr_commenter_batch />Some comments on commits martinpovolny/manageiq@c9de5ff~...c02e8ea spec/controllers/application_controller/buttons_spec.rb
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
miq-bot
Nov 27, 2016
Member
Checked commits martinpovolny/manageiq@c9de5ff~...c02e8ea with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
8 files checked, 0 offenses detected
Everything looks good.
|
Checked commits martinpovolny/manageiq@c9de5ff~...c02e8ea with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Look goos, thanks. |
gmcculloug
merged commit 6502d59
into
ManageIQ:master
Nov 28, 2016
gmcculloug
added this to the Sprint 50 Ending Dec 5, 2016 milestone
Nov 28, 2016
dclarizio
added
the
blocker
label
Nov 28, 2016
simaishi
removed
the
blocker
label
Nov 29, 2016
h-kataria
referenced this pull request
Dec 5, 2016
Merged
Fixed code that sets values of button_image, display & open_url fields #13001
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
simaishi
Jan 6, 2017
Contributor
Euwe backport conflict:
$ git cherry-pick -e -x -m 1 6502d59
error: could not apply 6502d59... Merge pull request #10118 from martinpovolny/button_launch_url
$ git diff
diff --cc app/controllers/application_controller/buttons.rb
index cf250b6,54095da..0000000
--- a/app/controllers/application_controller/buttons.rb
+++ b/app/controllers/application_controller/buttons.rb
@@@ -264,12 -276,15 +276,19 @@@ module ApplicationController::Button
options[:target_id] = obj.id
options[:target_kls] = obj.class.name
dialog_initialize(button.resource_action, options)
+ elsif button.options && button.options.key?(:open_url) && button.options[:open_url]
+ task_id = button.invoke_async(obj)
+ initiate_wait_for_task(:task_id => task_id, :action => :custom_button_done)
else
begin
++<<<<<<< HEAD
+ button.invoke(obj) # Run the task
++=======
+ button.invoke(obj)
++>>>>>>> 6502d59... Merge pull request #10118 from martinpovolny/button_launch_url
rescue StandardError => bang
add_flash(_("Error executing: \"%{task_description}\" %{error_message}") %
- {:task_description => params[:desc], :error_message => bang.message}, :error) # Push msg and error flag
+ {:task_description => params[:desc], :error_message => bang.message}, :error)
else
add_flash(_("\"%{task_description}\" was executed") % {:task_description => params[:desc]})
end
|
Euwe backport conflict: $ git diff
diff --cc app/controllers/application_controller/buttons.rb
index cf250b6,54095da..0000000
--- a/app/controllers/application_controller/buttons.rb
+++ b/app/controllers/application_controller/buttons.rb
@@@ -264,12 -276,15 +276,19 @@@ module ApplicationController::Button
options[:target_id] = obj.id
options[:target_kls] = obj.class.name
dialog_initialize(button.resource_action, options)
+ elsif button.options && button.options.key?(:open_url) && button.options[:open_url]
+ task_id = button.invoke_async(obj)
+ initiate_wait_for_task(:task_id => task_id, :action => :custom_button_done)
else
begin
++<<<<<<< HEAD
+ button.invoke(obj) # Run the task
++=======
+ button.invoke(obj)
++>>>>>>> 6502d59... Merge pull request #10118 from martinpovolny/button_launch_url
rescue StandardError => bang
add_flash(_("Error executing: \"%{task_description}\" %{error_message}") %
- {:task_description => params[:desc], :error_message => bang.message}, :error) # Push msg and error flag
+ {:task_description => params[:desc], :error_message => bang.message}, :error)
else
add_flash(_("\"%{task_description}\" was executed") % {:task_description => params[:desc]})
end
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
simaishi
Jan 6, 2017
Contributor
@martinpovolny Please resolve conflict and make Euwe-specific PR (referencing this one) or suggest other PRs to backport.
|
@martinpovolny Please resolve conflict and make Euwe-specific PR (referencing this one) or suggest other PRs to backport. |
simaishi
added
the
euwe/conflict
label
Jan 6, 2017
This was referenced Jan 11, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Backported to Euwe via #13449 |
martinpovolny commentedJul 28, 2016
•
edited by dclarizio
https://bugzilla.redhat.com/show_bug.cgi?id=1399368
Purpose or Intent
Extension to custom buttons where:
SystemConsolemodel).or even open a HTML5 VNC client to a provided websocket URL (not in this PR).A simple usecase is opening a custom web page that is not available immediately, but needs to be made ready by the automate script.
The greater idea is than an automate script would somehow build a chain of proxy servers for VNC connection and the ManageIQ UI would open a HTML5 VNC client that would connect through that tunnel.
Example usage from automate:
press the button.
FIXME (for a follow up PR?)
SystemConsolewe might need to do some cleanups (websocket proxy) or 2nd level proxy (#11273). However it makes no sense to use the proxies together with this on a single VM so this is not a big issue.set_remote_console_urlmethod exposed to automate.