New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change API namespace from ManageIQ::API -> Api #10823

Merged
merged 1 commit into from Aug 30, 2016

Conversation

Projects
None yet
5 participants
@imtayadeway
Contributor

imtayadeway commented Aug 26, 2016

Purpose or Intent

@miq-bot assign @abellotti
@miq-bot add-label api, refactoring

@imtayadeway

View changes

Show outdated Hide outdated config/routes.rb

@abellotti abellotti added the darga/no label Aug 26, 2016

@imtayadeway imtayadeway reopened this Aug 26, 2016

@imtayadeway

This comment has been minimized.

Show comment
Hide comment
@imtayadeway

imtayadeway Aug 29, 2016

Contributor

@Fryguy @abellotti it looks like the introduction of 34a32ab8ba532b71de68d3710af82d97d1fa5d13, while allowing the API to work nicely, caused some wide-ranging failures throughout the system owing to inconsistent naming. Any preference on how to proceed?

Contributor

imtayadeway commented Aug 29, 2016

@Fryguy @abellotti it looks like the introduction of 34a32ab8ba532b71de68d3710af82d97d1fa5d13, while allowing the API to work nicely, caused some wide-ranging failures throughout the system owing to inconsistent naming. Any preference on how to proceed?

@imtayadeway imtayadeway changed the title from Change API namespace from ManageIQ::API -> API to Change API namespace from ManageIQ::API -> Api Aug 30, 2016

@Fryguy

This comment has been minimized.

Show comment
Hide comment
@Fryguy

Fryguy Aug 30, 2016

Member

@imtayadeway Can you look at the alignment issues as found by the bot? I think that was introduced here in the re-namespacing effort

Member

Fryguy commented Aug 30, 2016

@imtayadeway Can you look at the alignment issues as found by the bot? I think that was introduced here in the re-namespacing effort

@Fryguy

This comment has been minimized.

Show comment
Hide comment
@Fryguy

Fryguy Aug 30, 2016

Member

Otherwise LGTM 👍

Member

Fryguy commented Aug 30, 2016

Otherwise LGTM 👍

@miq-bot

This comment has been minimized.

Show comment
Hide comment
@miq-bot

miq-bot Aug 30, 2016

Member

Checked commit imtayadeway@425cd76 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
65 files checked, 86 offenses detected

app/controllers/api/base_controller.rb

app/controllers/api/base_controller/arbitration_profiles.rb

app/controllers/api/base_controller/authentication.rb

app/controllers/api/base_controller/blueprints.rb

app/controllers/api/base_controller/custom_attributes.rb

app/controllers/api/base_controller/features.rb

  • - Line 11, Col 7 - Metrics/AbcSize - Assignment Branch Condition size for features_assign_resource is too high. [24.84/20]
  • - Line 40, Col 7 - Metrics/AbcSize - Assignment Branch Condition size for features_unassign_resource is too high. [23.87/20]

app/controllers/api/base_controller/generic.rb

app/controllers/api/base_controller/hosts.rb

app/controllers/api/base_controller/instances.rb

app/controllers/api/base_controller/logger.rb

app/controllers/api/base_controller/manager.rb

app/controllers/api/base_controller/normalizer.rb

app/controllers/api/base_controller/parameters.rb

app/controllers/api/base_controller/parser.rb

app/controllers/api/base_controller/policies.rb

app/controllers/api/base_controller/providers.rb

app/controllers/api/base_controller/rates.rb

app/controllers/api/base_controller/renderer.rb

app/controllers/api/base_controller/request_tasks.rb

  • ❗️ - Line 12, Col 7 - Style/Alias - Use alias instead of alias_method in a module body.

app/controllers/api/base_controller/service_templates.rb

app/controllers/api/base_controller/tags.rb

app/controllers/api/base_controller/tenants.rb

app/controllers/api/base_controller/vms.rb

Member

miq-bot commented Aug 30, 2016

Checked commit imtayadeway@425cd76 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
65 files checked, 86 offenses detected

app/controllers/api/base_controller.rb

app/controllers/api/base_controller/arbitration_profiles.rb

app/controllers/api/base_controller/authentication.rb

app/controllers/api/base_controller/blueprints.rb

app/controllers/api/base_controller/custom_attributes.rb

app/controllers/api/base_controller/features.rb

  • - Line 11, Col 7 - Metrics/AbcSize - Assignment Branch Condition size for features_assign_resource is too high. [24.84/20]
  • - Line 40, Col 7 - Metrics/AbcSize - Assignment Branch Condition size for features_unassign_resource is too high. [23.87/20]

app/controllers/api/base_controller/generic.rb

app/controllers/api/base_controller/hosts.rb

app/controllers/api/base_controller/instances.rb

app/controllers/api/base_controller/logger.rb

app/controllers/api/base_controller/manager.rb

app/controllers/api/base_controller/normalizer.rb

app/controllers/api/base_controller/parameters.rb

app/controllers/api/base_controller/parser.rb

app/controllers/api/base_controller/policies.rb

app/controllers/api/base_controller/providers.rb

app/controllers/api/base_controller/rates.rb

app/controllers/api/base_controller/renderer.rb

app/controllers/api/base_controller/request_tasks.rb

  • ❗️ - Line 12, Col 7 - Style/Alias - Use alias instead of alias_method in a module body.

app/controllers/api/base_controller/service_templates.rb

app/controllers/api/base_controller/tags.rb

app/controllers/api/base_controller/tenants.rb

app/controllers/api/base_controller/vms.rb

@abellotti

This comment has been minimized.

Show comment
Hide comment
@abellotti

abellotti Aug 30, 2016

Member

👍 waiting for 🍏

Member

abellotti commented Aug 30, 2016

👍 waiting for 🍏

@abellotti abellotti merged commit 5c6f9fb into ManageIQ:master Aug 30, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 36.622%
Details

@imtayadeway imtayadeway deleted the imtayadeway:api/namespacing-ii branch Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment