New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(-‸ლ) Actually skip settings specs #10857

Merged
merged 1 commit into from Aug 29, 2016

Conversation

Projects
None yet
3 participants
@chrisarcand
Member

chrisarcand commented Aug 29, 2016

Skips all settings specs as there's a known failure causing a red build, for now

@Fryguy I didn't realize it's non-deterministic enough to be different tests within that very file, and only skipped according to one failure.

Here's a cleaner skip-all instead, sorry for the noise.

@miq-bot assign @Fryguy

@miq-bot

This comment has been minimized.

Show comment
Hide comment
@miq-bot

miq-bot Aug 29, 2016

Member

Checked commit chrisarcand@f6c8271 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. ⭐️

Member

miq-bot commented Aug 29, 2016

Checked commit chrisarcand@f6c8271 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. ⭐️

@Fryguy Fryguy merged commit e5062b3 into ManageIQ:master Aug 29, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.6%) to 8.052%
Details

@Fryguy Fryguy added this to the Sprint 46 Ending Sep 12, 2016 milestone Aug 29, 2016

@Fryguy Fryguy added the darga/no label Aug 29, 2016

@chrisarcand chrisarcand deleted the chrisarcand:remove-settings-specs branch Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment