New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Entrypoint module with ApiController #10880

Merged
merged 1 commit into from Aug 30, 2016

Conversation

Projects
None yet
3 participants
@imtayadeway
Contributor

imtayadeway commented Aug 30, 2016

Purpose or Intent

  • pulls this code out of the Api::BaseController
  • allows for the more natural get "/api(/:version)" => "api#index"

@miq-bot add-label api, refactoring
@miq-bot assign @abellotti

Replace Entrypoint module with ApiController
* pulls this code out of the Api::BaseController
* allows for the more natural `get "/api(/:version)" => "api#index"`
@miq-bot

This comment has been minimized.

Show comment
Hide comment
@miq-bot

miq-bot Aug 30, 2016

Member

Checked commit imtayadeway@530911f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
3 files checked, 0 offenses detected
Everything looks good. 🍰

Member

miq-bot commented Aug 30, 2016

Checked commit imtayadeway@530911f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
3 files checked, 0 offenses detected
Everything looks good. 🍰

@abellotti

This comment has been minimized.

Show comment
Hide comment
@abellotti

abellotti Aug 30, 2016

Member

👍

Member

abellotti commented Aug 30, 2016

👍

@abellotti abellotti merged commit fe6b2a7 into ManageIQ:master Aug 30, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.008%) to 36.655%
Details

@imtayadeway imtayadeway deleted the imtayadeway:refactor/api-entrypoint branch Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment