New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archived: Scope for not archived nor orphaned #10920

Merged
merged 2 commits into from Aug 31, 2016

Conversation

Projects
None yet
3 participants
@kbrock
Member

kbrock commented Aug 31, 2016

We are bringing back all vms to prune out the archived and orphaned ones.

There is a TODO to turn it into a scope.

This PR introduces the scope.

kbrock added some commits Aug 31, 2016

Add Vm.not_archived_nor_orphaned scope
instead of bringing back all vms, bring back only those not archived

@kbrock kbrock changed the title from Archived vms scopes to Archived: Scope for not archived nor orphaned Aug 31, 2016

@miq-bot

This comment has been minimized.

Show comment
Hide comment
@miq-bot

miq-bot Aug 31, 2016

Member

Checked commits kbrock/manageiq@7b73bb0~...0b811b2 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
3 files checked, 0 offenses detected
Everything looks good. 👍

Member

miq-bot commented Aug 31, 2016

Checked commits kbrock/manageiq@7b73bb0~...0b811b2 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
3 files checked, 0 offenses detected
Everything looks good. 👍

@kbrock

This comment has been minimized.

Show comment
Hide comment
@kbrock

kbrock Aug 31, 2016

Member

@gtanzillo renamed to use 'nor'

Member

kbrock commented Aug 31, 2016

@gtanzillo renamed to use 'nor'

@gtanzillo

This comment has been minimized.

Show comment
Hide comment
@gtanzillo

gtanzillo Aug 31, 2016

Member

👍 LGTM

Member

gtanzillo commented Aug 31, 2016

👍 LGTM

@gtanzillo gtanzillo merged commit 3d56c75 into ManageIQ:master Aug 31, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0001%) to 36.643%
Details

@kbrock kbrock deleted the kbrock:archived_vms_scopes branch Aug 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment