Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable My Filters in Datastores #11452

Merged
merged 1 commit into from Sep 23, 2016

Conversation

hstastna
Copy link
Contributor

@hstastna hstastna commented Sep 22, 2016

fixing https://bugzilla.redhat.com/show_bug.cgi?id=1361224

Make My Filters in Datastores clickable
when reaching Compute -> Infrastructure -> Datastores.

Before:
datastores_before

After:
datastores_after

@hstastna
Copy link
Contributor Author

Actually, I have found a problem regarding the bug: there is an infinite spinner after using some of My Filters and clicking on "Clear". Probably there is a problem in some javascript files. Should I create an issue for it?

fixing https://bugzilla.redhat.com/show_bug.cgi?id=1361224

Make My Filters in Datastores clickable
when reaching Compute -> Infrastructure -> Datastores.
@miq-bot
Copy link
Member

miq-bot commented Sep 22, 2016

Checked commit hstastna@7477720 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🏆

@dclarizio
Copy link

Actually, I have found a problem regarding the bug: there is an infinite spinner after using some of My Filters and clicking on "Clear". Probably there is a problem in some javascript files. Should I create an issue for it?

@hstastna please do, but verify if it's in Darga as well since we will need a BZ if it is . . . will merge this one now tho . . . Thx, Dan

@dclarizio dclarizio merged commit 34b4dfd into ManageIQ:master Sep 23, 2016
@dclarizio dclarizio added this to the Sprint 47 Ending Oct 3, 2016 milestone Sep 23, 2016
chessbyte pushed a commit that referenced this pull request Sep 29, 2016
Enable My Filters in Datastores
(cherry picked from commit 34b4dfd)
@chessbyte
Copy link
Member

Euwe Backport details:

$ git log
commit 0f29e345445e79f8ab69b715af5313ca5cd2063e
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Fri Sep 23 10:45:57 2016 -0700

    Merge pull request #11452 from hstastna/My_filters_in_Datastores

    Enable My Filters in Datastores
    (cherry picked from commit 34b4dfd272ac7f927065619b147b8d89efc3c77c)

@chessbyte
Copy link
Member

chessbyte pushed a commit that referenced this pull request Oct 7, 2016
@chessbyte
Copy link
Member

Darga Backport details:

$ git log
commit 628b97164e9a39619217b9455b15801d3f2f7990
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Fri Sep 23 10:45:57 2016 -0700

    Merge pull request #11452 from hstastna/My_filters_in_Datastores

    Enable My Filters in Datastores
    (cherry picked from commit 34b4dfd272ac7f927065619b147b8d89efc3c77c)

    https://bugzilla.redhat.com/show_bug.cgi?id=1379727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants