Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy jquery-ui MIQ theme #12335

Merged
merged 1 commit into from Nov 1, 2016

Conversation

@epwinchell
Copy link
Member

epwinchell commented Nov 1, 2016

@epwinchell

This comment has been minimized.

Copy link
Member Author

epwinchell commented Nov 1, 2016

@miq-bot add_label ui, technical debt

@epwinchell

This comment has been minimized.

Copy link
Member Author

epwinchell commented Nov 1, 2016

@miq-bot assign @himdel

@epwinchell

This comment has been minimized.

Copy link
Member Author

epwinchell commented Nov 1, 2016

@himdel Please review

@epwinchell

This comment has been minimized.

Copy link
Member Author

epwinchell commented Nov 1, 2016

cc @jrafanie @Fryguy ✂️✂️🎃✂️

@epwinchell epwinchell changed the title Remove legacy jquery-ui styling Remove legacy jquery-ui MIQ theme Nov 1, 2016
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Nov 1, 2016

Checked commit epwinchell@2cdd0c1 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🍰

@himdel

This comment has been minimized.

Copy link
Contributor

himdel commented Nov 1, 2016

Closes #5849 :)

But.. you're sure we're not using any jquery-ui styles anywhere anymore? I couldn't figure out a way to make sure, given the very generic names of those classes..

But then again, assuming euwe/no, why not try and see what happens 👍 :)

@jrafanie

This comment has been minimized.

Copy link
Member

jrafanie commented Nov 1, 2016

cc @jrafanie @Fryguy ✂️✂️🎃✂️

+0 −569

It's not too late for treats like this! Thanks @epwinchell. Out with the old.

@Fryguy

This comment has been minimized.

Copy link
Member

Fryguy commented Nov 1, 2016

@epwinchell has been on a roll lately with all of this cleanup 😍

@chrisarcand chrisarcand merged commit 08c49ca into ManageIQ:master Nov 1, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-28.6%) to 8.098%
Details
@chrisarcand chrisarcand added the euwe/no label Nov 1, 2016
@chrisarcand chrisarcand assigned chrisarcand and unassigned himdel Nov 1, 2016
@epwinchell

This comment has been minimized.

Copy link
Member Author

epwinchell commented Nov 1, 2016

@himdel I searched on the classes and couldn't find anything (we used to use it for accordions and tabs). As far as I know, the only place we still use jquery-ui JS is for the widget drag-and-drop.

@himdel

This comment has been minimized.

Copy link
Contributor

himdel commented Nov 1, 2016

sounds about right.. fingers crossed then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.