Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Move snapshot code to Vm in service model. #12726
The snapshot code in automate was moved from VmOrTemplate to VMware specific class by PR #3707 when VMware was the only class that supported snapshot.
But snapshot support has been added to RHEVM and Openstack as of version Euwe.
@lfu You are now exposing these methods on every VM/Template which is not valid in a lot of cases. Before it was only exposed on VMs from automate and I think we should keep it at that level, just move it into the base VM service model.
Also, we should raise an error for providers where we do not support snapshot features with a "Feature not supported" error message.
@durandom I see there is a
For example, VMware supports
I guess we would have to add all operations as features and then ask the Vm if it supports that operation. So far I only see snapshot features for openstack cloud_volumes and rh vms.
❯ git --no-pager grep -E 'supports(_not)? :.*snapshot' app/models/manageiq/providers/openstack/cloud_manager/cloud_volume.rb: supports :snapshot_create app/models/manageiq/providers/redhat/infra_manager/vm/operations/snapshot.rb: supports :snapshots do
Checked commit lfu@3569ecf with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
Nov 21, 2016
Euwe backport details: