Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set start date explicitly only when changing schedule interval #12816

Conversation

Projects
None yet
7 participants
@mzazrivec
Copy link
Contributor

mzazrivec commented Nov 23, 2016

Reproducer:

  1. Cloud Intel -> Reports -> Schedules -> Edit existing schedule
  2. Change schedule start date
  3. Notice the start date will be set back to either today (hourly schedule) or tomorrow (all the other).

https://bugzilla.redhat.com/show_bug.cgi?id=1392351

Set start date explicitly only when changing schedule interval
Otherwise the start date would be set every time, also when
changing the start date.

https://bugzilla.redhat.com/show_bug.cgi?id=1392351

@mzazrivec mzazrivec force-pushed the mzazrivec:set_start_date_only_when_changing_schedule_interval branch to 611bdfa Nov 24, 2016

@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Nov 24, 2016

Checked commit mzazrivec@611bdfa with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 1 offense detected

app/controllers/report_controller/schedules.rb

@psachin

This comment has been minimized.

Copy link

psachin commented Nov 25, 2016

This fixes the issue but now can also set past date.

https://www.youtube.com/watch?v=iC_dlt9ca_w

@martinpovolny martinpovolny merged commit d794686 into ManageIQ:master Nov 25, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0003%) to 34.9%
Details
@martinpovolny

This comment has been minimized.

Copy link
Contributor

martinpovolny commented Nov 25, 2016

@mzazrivec : please, address the feedback by @psachin in a follow up PR

@mzazrivec mzazrivec deleted the mzazrivec:set_start_date_only_when_changing_schedule_interval branch Nov 29, 2016

@dclarizio dclarizio added the darga/yes label Nov 29, 2016

@mzazrivec mzazrivec added the blocker label Nov 29, 2016

@simaishi simaishi removed the blocker label Nov 29, 2016

@simaishi

This comment has been minimized.

Copy link
Contributor

simaishi commented Nov 29, 2016

Removing blocker flag, as the BZ isn't marked as blocker for the upcoming release.

@chessbyte

This comment has been minimized.

Copy link
Member

chessbyte commented Dec 13, 2016

chessbyte added a commit that referenced this pull request Dec 13, 2016

Merge pull request #12816 from mzazrivec/set_start_date_only_when_cha…
…nging_schedule_interval

Set start date explicitly only when changing schedule interval
(cherry picked from commit d794686)

https://bugzilla.redhat.com/show_bug.cgi?id=1399759
@chessbyte

This comment has been minimized.

Copy link
Member

chessbyte commented Dec 13, 2016

Darga Backport details:

$ git log -1
commit a52c3aaf58466ddb9a73e5bf521c1cc7f50034c1
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Fri Nov 25 23:12:23 2016 +0100

    Merge pull request #12816 from mzazrivec/set_start_date_only_when_changing_schedule_interval
    
    Set start date explicitly only when changing schedule interval
    (cherry picked from commit d794686d151c2284fdd258e4040e5477e76237b0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1399759

simaishi added a commit that referenced this pull request Jan 6, 2017

Merge pull request #12816 from mzazrivec/set_start_date_only_when_cha…
…nging_schedule_interval

Set start date explicitly only when changing schedule interval
(cherry picked from commit d794686)

https://bugzilla.redhat.com/show_bug.cgi?id=1399669
@simaishi

This comment has been minimized.

Copy link
Contributor

simaishi commented Jan 6, 2017

Euwe backport details:

$ git log -1
commit 4e2baa66b6e19dd118ba37c1a3067b76ad4df35b
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Fri Nov 25 23:12:23 2016 +0100

    Merge pull request #12816 from mzazrivec/set_start_date_only_when_changing_schedule_interval
    
    Set start date explicitly only when changing schedule interval
    (cherry picked from commit d794686d151c2284fdd258e4040e5477e76237b0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1399669

@simaishi simaishi added euwe/backported and removed euwe/yes labels Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.