Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give policy event sample reports better names #12934

Merged
merged 1 commit into from Nov 30, 2016

Conversation

Projects
None yet
4 participants
@dclarizio
Copy link

commented Nov 30, 2016

Original report names simply had "Sample 1" and "Sample 2" suffixes. Changed these to be more descriptive as one report is for events for last week (Sun through Sat) and the other is for events from the last 7 days.

https://bugzilla.redhat.com/show_bug.cgi?id=1391900

@miq-bot

This comment has been minimized.

Copy link
Member

commented Nov 30, 2016

Checked commit dclarizio@1e66600 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🍰

@h-kataria h-kataria merged commit 8727594 into ManageIQ:master Nov 30, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 35.041%
Details

@dclarizio dclarizio deleted the dclarizio:fix_policy_event_report_names branch Dec 1, 2016

simaishi added a commit that referenced this pull request Jan 9, 2017

Merge pull request #12934 from dclarizio/fix_policy_event_report_names
Give policy event sample reports better names
(cherry picked from commit 8727594)

https://bugzilla.redhat.com/show_bug.cgi?id=1401017
@simaishi

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2017

Euwe backport details:

$ git log -1
commit 07271791b474d735b33af8521397f8f11bf755fb
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed Nov 30 18:17:20 2016 -0500

    Merge pull request #12934 from dclarizio/fix_policy_event_report_names
    
    Give policy event sample reports better names
    (cherry picked from commit 8727594fa165aeae61ff4fb86b8eb91933c1a158)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1401017

@simaishi simaishi added euwe/backported and removed euwe/yes labels Jan 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.