Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new features for the Ansible UI move to the Automation tab #13526

Merged
merged 3 commits into from Jan 31, 2017

Conversation

@lgalis
Copy link
Contributor

lgalis commented Jan 16, 2017

Added new features for the Ansible UI move to the Automation tab

Links [Optional]

https://www.pivotaltracker.com/n/projects/1937457/stories/137618573

This PR is required for ManageIQ/manageiq-ui-classic#170

@lgalis

This comment has been minimized.

Copy link
Contributor Author

lgalis commented Jan 16, 2017

@miq-bot add_label ui, enhancement, wip

@lgalis lgalis force-pushed the lgalis:move_ansible_ui_to_automation_main branch 7 times, most recently Jan 18, 2017
@lgalis

This comment has been minimized.

Copy link
Contributor Author

lgalis commented Jan 25, 2017

@dclarizio - please review

@lgalis lgalis changed the title [WIP] Added new features for the Ansible UI move to the Automation tab Added new features for the Ansible UI move to the Automation tab Jan 25, 2017
@lgalis

This comment has been minimized.

Copy link
Contributor Author

lgalis commented Jan 25, 2017

@miq-bot remove_label wip

db/fixtures/miq_product_features.yml Outdated
- :name: Ansible Tower
:description: Everything under Ansible Tower
:feature_type: node
:identifier: ansible_tower

This comment has been minimized.

Copy link
@Fryguy

Fryguy Jan 27, 2017

Member

I am really against us hardcoding this as ansible_tower. It should be reflected as AutomationManager, or, perhaps ExternalAutomationManager. The UI should never code to a specific provider but instead to the abstraction layer above it. cc @dclarizio @chessbyte

This comment has been minimized.

Copy link
@lgalis

lgalis Jan 27, 2017

Author Contributor

@Fryguy - I agree - I had Automation Manager first, then discussed with @dclarizio and changed it to ansible_tower. I can change this to automation manager rather than external, and we can name the internal something else.

@lgalis lgalis force-pushed the lgalis:move_ansible_ui_to_automation_main branch 3 times, most recently Jan 27, 2017
@lgalis

This comment has been minimized.

Copy link
Contributor Author

lgalis commented Jan 27, 2017

@Fryguy - updated

db/fixtures/miq_product_features.yml Outdated
- :name: Configured Systems
:description: Everything under Configured Systems accordion
:feature_type: node
:identifier: automation_manager_cs_filter_accord

This comment has been minimized.

Copy link
@Fryguy

Fryguy Jan 30, 2017

Member

@lgalis Should this be abbreviated to _cs_? I'm asking because

  1. the ones below, like automation_manager_configured_system_control are not abbreviated, and I feel it should be consistent.
  2. Abbreviation of cs for configured_system can be confused with configuration_script. Down below, configuration_script is spelled out (for view: automation_manager_configuration_script_control)
db/fixtures/miq_product_features.yml Outdated
- :name: Create Service Dialog
:description: Create Service Dialog
:feature_type: admin
:identifier: automation_manager_configscript_service_dialog

This comment has been minimized.

Copy link
@Fryguy

Fryguy Jan 30, 2017

Member

and this one is different in another way

db/fixtures/miq_product_features.yml Outdated
- :name: View
:description: View Configured Systems
:feature_type: view
:identifier: automation_manager_cs_filter_accord_view

This comment has been minimized.

Copy link
@Fryguy

Fryguy Jan 30, 2017

Member

One more _cs_

@lgalis lgalis force-pushed the lgalis:move_ansible_ui_to_automation_main branch to 9a674bc Jan 30, 2017
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Jan 31, 2017

Checked commits lgalis/manageiq@7afe4b6~...33ae947 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🏆

@lgalis

This comment has been minimized.

Copy link
Contributor Author

lgalis commented Jan 31, 2017

@Fryguy - please review

@Fryguy Fryguy merged commit c40655c into ManageIQ:master Jan 31, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 42.417%
Details
@lgalis lgalis deleted the lgalis:move_ansible_ui_to_automation_main branch Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.