Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Add OPTIONS method to Clusters and Hosts #13574

Merged

Conversation

Projects
None yet
4 participants
@AparnaKarve
Copy link
Contributor

AparnaKarve commented Jan 18, 2017

The OPTIONS method was added to Clusters and Hosts in order to retrieve the metadata node_types on those collections

@AparnaKarve

This comment has been minimized.

Copy link
Contributor Author

AparnaKarve commented Jan 18, 2017

@abellotti @imtayadeway Please review.

@imtayadeway Thanks for the tip on OPTIONS!

@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Jan 18, 2017

Checked commits AparnaKarve/manageiq@76fa797~...1cd789f with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
4 files checked, 0 offenses detected
Everything looks good. ⭐️

@abellotti

This comment has been minimized.

Copy link
Member

abellotti commented Jan 19, 2017

👍 This LGTM!! Thanks @AparnaKarve, waiting for 🍏

@abellotti abellotti merged commit 2193bda into ManageIQ:master Jan 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 42.646%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.