Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily bypass asset lookup in tests #13801

Merged
merged 1 commit into from Feb 7, 2017

Conversation

hayesr
Copy link
Contributor

@hayesr hayesr commented Feb 7, 2017

Bypass asset lookup in tests until calls to image_path in models can be found and removed.

This is based on a suggestion by @himdel. It addresses #13792.

@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2017

Checked commit hayesr@4247e02 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 1 offense detected

spec/spec_helper.rb

  • ⚠️ - Line 19, Col 24 - Lint/UnusedMethodArgument - Unused method argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used.

@jrafanie
Copy link
Member

jrafanie commented Feb 7, 2017

This is good enough for now to get us 💚 again

@jrafanie jrafanie added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 7, 2017
@jrafanie jrafanie merged commit 4726e28 into ManageIQ:master Feb 7, 2017
@jrafanie
Copy link
Member

jrafanie commented Feb 7, 2017

@hayesr do we need this on euwe?

@himdel
Copy link
Contributor

himdel commented Feb 8, 2017

Euwe is not split, so no need.

@miq-bot add_label euwe/no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants