Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing regions as a primary collection /api/regions #14109

Merged
merged 2 commits into from Mar 7, 2017

Conversation

@abellotti
Copy link
Member

abellotti commented Feb 28, 2017

  • /api/regions
  • Support queries of /api/regions
  • Support "query" post for bulk queries
@abellotti

This comment has been minimized.

Copy link
Member Author

abellotti commented Feb 28, 2017

This is a precursor for the settings support enhancements.

WIP, missing:

  • identifiers
  • rspecs
@abellotti abellotti force-pushed the abellotti:api_region branch Mar 2, 2017
@abellotti abellotti requested review from imtayadeway and h-kataria Mar 2, 2017
@abellotti

This comment has been minimized.

Copy link
Member Author

abellotti commented Mar 2, 2017

@imtayadeway please review

/cc @h-kataria for the miq_product_features changes, thanks!

@abellotti abellotti removed the wip label Mar 2, 2017
@abellotti abellotti changed the title [WIP] Exposing regions as a primary collection /api/regions Exposing regions as a primary collection /api/regions Mar 2, 2017
:identifier: region
:options:
- :collection
:verbs: *gp

This comment has been minimized.

Copy link
@imtayadeway

imtayadeway Mar 3, 2017

Contributor

Since you're adding post, can one update a region with the default implementation?

This comment has been minimized.

Copy link
@abellotti

abellotti Mar 3, 2017

Author Member

not today. This post is just for the bulk query implemented.

But shortly, it will also be used for updating settings.

@abellotti

This comment has been minimized.

Copy link
Member Author

abellotti commented Mar 6, 2017

ping @imtayadeway @h-kataria any changes needed here ?

@imtayadeway

This comment has been minimized.

Copy link
Contributor

imtayadeway commented Mar 6, 2017

@abellotti could you add a test to prove that the code added for region member GETs is needed/works?

Otherwise LGTM

abellotti added 2 commits Feb 28, 2017
- /api/regions
- Enhanced miq_product_features to support Region queries/edits
- Support queries of /api/regions
- Support "query" post for bulk queries
@abellotti abellotti force-pushed the abellotti:api_region branch to 4f674d3 Mar 6, 2017
@abellotti

This comment has been minimized.

Copy link
Member Author

abellotti commented Mar 6, 2017

Thanks @imtayadeway !! regions resources spec added.

@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Mar 6, 2017

Checked commits abellotti/manageiq@65f703f~...4f674d3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🍰

Copy link
Contributor

h-kataria left a comment

product features changes look good

@abellotti

This comment has been minimized.

Copy link
Member Author

abellotti commented Mar 7, 2017

Thanks @h-kataria for the review

Copy link
Member

gtanzillo left a comment

👍 LGTM

@gtanzillo gtanzillo merged commit cf439c2 into ManageIQ:master Mar 7, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 44.363%
Details
@abellotti abellotti deleted the abellotti:api_region branch Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.