Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow selecting resources from another region when creating a catalog item #14468

Conversation

@bdunne
Copy link
Member

bdunne commented Mar 22, 2017

When creating a catalog item, only allow selecting resources from the current region.

https://bugzilla.redhat.com/show_bug.cgi?id=1398725

@bdunne bdunne force-pushed the bdunne:dont_allow_selecting_resources_from_another_region_when_creating_a_catalog_item branch to 7853c6f Mar 22, 2017
@miq-bot miq-bot added the wip label Mar 22, 2017
@miq-bot

This comment has been minimized.

Copy link
Member

miq-bot commented Mar 22, 2017

Checked commits bdunne/manageiq@548d782~...7853c6f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 👍

@bdunne

This comment has been minimized.

Copy link
Member Author

bdunne commented Mar 23, 2017

@gtanzillo IIRC, this fits into our original Central Admin Service Provisioning story...
When creating a Catalog Item, that item should be created in the region in which its backing resources live (MiqTemplate in this case). So, you shouldn't be able to create a Catalog Item in the global region that is backed by resources in a remote region. If you want this Catalog Item, it should be created in the remote region, then it can be replicated up and ordered from the global region.
Please let me know if this is not correct.

@bdunne bdunne changed the title [WIP] Don't allow selecting resources from another region when creating a catalog item Don't allow selecting resources from another region when creating a catalog item Mar 23, 2017
@bdunne bdunne removed the wip label Mar 23, 2017
@gtanzillo

This comment has been minimized.

Copy link
Member

gtanzillo commented Mar 23, 2017

@bdunne

@gtanzillo IIRC, this fits into our original Central Admin Service Provisioning story...
When creating a Catalog Item, that item should be created in the region in which its backing resources live (MiqTemplate in this case). So, you shouldn't be able to create a Catalog Item in the global region that is backed by resources in a remote region. If you want this Catalog Item, it should be created in the remote region, then it can be replicated up and ordered from the global region.
Please let me know if this is not correct.

Yes, that's correct.

@gmcculloug

This comment has been minimized.

Copy link
Member

gmcculloug commented Mar 24, 2017

Look good to me. 👍

@gmcculloug gmcculloug merged commit 4c095ea into ManageIQ:master Mar 24, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 4.337%
Details
@bdunne bdunne deleted the bdunne:dont_allow_selecting_resources_from_another_region_when_creating_a_catalog_item branch Mar 24, 2017
@bdunne bdunne added the euwe/yes label Mar 24, 2017
simaishi added a commit that referenced this pull request Apr 13, 2017
…from_another_region_when_creating_a_catalog_item

Don't allow selecting resources from another region when creating a catalog item
(cherry picked from commit 4c095ea)

https://bugzilla.redhat.com/show_bug.cgi?id=1436236
@simaishi

This comment has been minimized.

Copy link
Contributor

simaishi commented Apr 13, 2017

Euwe backport details:

$ git log -1
commit a7a84d38806cde0289dcfeaf9836dfdbeab63051
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Fri Mar 24 17:11:54 2017 -0400

    Merge pull request #14468 from bdunne/dont_allow_selecting_resources_from_another_region_when_creating_a_catalog_item
    
    Don't allow selecting resources from another region when creating a catalog item
    (cherry picked from commit 4c095eacb594cfd3b733555ec8b51cb6f10d7e1d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1436236
@simaishi simaishi added euwe/backported and removed euwe/yes labels Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.